LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Brandon Philips <brandon@ifup.org>
Cc: Hans-J??rgen Koch <hjk@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UIO: introduce sysfs_ops for map_attr_ktype
Date: Tue, 19 Feb 2008 22:54:06 -0800	[thread overview]
Message-ID: <20080220065406.GB22884@kroah.com> (raw)
In-Reply-To: <20080219095505.GA875@plankton.ifup.org>

On Tue, Feb 19, 2008 at 01:55:05AM -0800, Brandon Philips wrote:
> This fixes two bugs with UIO that cropped up recently in -rc1
> 
> 1) WARNING: at fs/sysfs/file.c:334 sysfs_open_file when trying to open
>    a map addr/size file - complaining about missing sysfs_ops for ktype
>         
> 2) Permission denied when reading uio/uio0/maps/map0/{addr,size} when
>    files are mode S_IRUGO
> 
> Also fix a typo: attr_attribute -> addr_attribute
> 
> Signed-off-by: Brandon Philips <bphilips@suse.de>

Hm, I thought I could get away with just using a kobject attribute, not
a special one.

Thanks for fixing this, it was my fault.

greg k-h

      parent reply	other threads:[~2008-02-20  6:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 17:03 UIO sysfs attributes broken in 2.6.25-rc1 Hans-Jürgen Koch
2008-02-13 17:33 ` Greg KH
2008-02-19  9:55   ` [PATCH] UIO: introduce sysfs_ops for map_attr_ktype Brandon Philips
2008-02-19 12:12     ` Hans-Jürgen Koch
2008-02-20  6:54     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080220065406.GB22884@kroah.com \
    --to=greg@kroah.com \
    --cc=brandon@ifup.org \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] UIO: introduce sysfs_ops for map_attr_ktype' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).