From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758711AbYBTKJo (ORCPT ); Wed, 20 Feb 2008 05:09:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752332AbYBTKJg (ORCPT ); Wed, 20 Feb 2008 05:09:36 -0500 Received: from wavehammer.waldi.eu.org ([82.139.201.20]:56071 "EHLO wavehammer.waldi.eu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbYBTKJf (ORCPT ); Wed, 20 Feb 2008 05:09:35 -0500 Date: Wed, 20 Feb 2008 11:09:33 +0100 From: Bastian Blank To: Heiko Carstens Cc: Segher Boessenkool , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky Subject: Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug. Message-ID: <20080220100933.GA20162@wavehammer.waldi.eu.org> Mail-Followup-To: Bastian Blank , Heiko Carstens , Segher Boessenkool , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky References: <20080219144047.587547541@de.ibm.com> <20080219144504.392301782@de.ibm.com> <20080219151355.GA24547@wavehammer.waldi.eu.org> <20080219153855.GA11599@osiris.boeblingen.de.ibm.com> <20080219154149.GB11599@osiris.boeblingen.de.ibm.com> <0d276daad249ac20ae922f4aa9a6e88b@kernel.crashing.org> <20080220094552.GA12635@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080220094552.GA12635@osiris.boeblingen.de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2008 at 10:45:52AM +0100, Heiko Carstens wrote: > - copy_page(lowcore, &S390_lowcore); > + memcpy(lowcore, &S390_lowcore, 512); Okay > memset((void *)lowcore + 512, 0, sizeof(*lowcore) - 512); Not completely okay. void pointer are not allowed in arithmetic. gcc handles void * as char * in this case, but I think it should usualy be avoided. Bastian -- Peace was the way. -- Kirk, "The City on the Edge of Forever", stardate unknown