LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: david-b@pacbell.net, spi-devel-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: atmel_spi clock polarity
Date: Wed, 20 Feb 2008 10:34:46 +0100	[thread overview]
Message-ID: <20080220103446.1621c81f@dhcp-252-066.norway.atmel.com> (raw)
In-Reply-To: <20080220.142109.11595419.nemoto@toshiba-tops.co.jp>

On Wed, 20 Feb 2008 14:21:09 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:

> On Mon, 18 Feb 2008 15:31:58 +0100, Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> > > Anyway, I will try your patch in a few days.
> > 
> > Ok, thanks. If it works, that would be great, but given your
> > description above I'm not sure if I dare hope for it.
> 
> Unfortunately it did not work.  The clock state did not change by
> writing MR register.

Ok, thanks for testing.

In that case, I think the best fix is to let NPCS0 stay selected
permanently in MR and overwrite CSR0 with to the new slave's settings
before asserting CS. But that's a more complicated change, and I don't
know how it will affect the AT91RM9200 special cases.

So I suggest we merge your patch for 2.6.25, and try to optimize it
for 2.6.26.

David, do you want me to pass on the patch with my signoff or just ask
Andrew to add my Acked-by to the patch already in mm?

Haavard

  reply	other threads:[~2008-02-20  9:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16 13:32 Atsushi Nemoto
2008-02-18 11:42 ` Haavard Skinnemoen
2008-02-18 14:12   ` Atsushi Nemoto
2008-02-18 14:31     ` Haavard Skinnemoen
2008-02-20  5:21       ` Atsushi Nemoto
2008-02-20  9:34         ` Haavard Skinnemoen [this message]
2008-02-20  9:50           ` Atsushi Nemoto
2008-02-21  1:33             ` David Brownell
2008-02-21  1:32           ` David Brownell
2008-02-18 19:57     ` [spi-devel-general] " David Brownell
2008-02-18 22:49       ` Haavard Skinnemoen
2008-02-19 14:51         ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080220103446.1621c81f@dhcp-252-066.norway.atmel.com \
    --to=hskinnemoen@atmel.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --subject='Re: atmel_spi clock polarity' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).