LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] lguest: fix undefined asm-offsets symbols
@ 2008-02-20 20:21 Kyle McMartin
  2008-03-04  0:14 ` Rusty Russell
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle McMartin @ 2008-02-20 20:21 UTC (permalink / raw)
  To: linux-kernel; +Cc: lguest, rusty, fedora-kernel-list

lguest uses asm-offsets to generate ... offsets, obviously, for use
in the lguest switcher code. When the hypervisor code is built as a
module though, the asm offsets it needs won't be generated since
CONFIG_LGUEST will be undefined.

Signed-off-by: Kyle McMartin <kmcmartin@redhat.com>

---
diff --git a/arch/x86/kernel/asm-offsets_32.c b/arch/x86/kernel/asm-offsets_32.c
index a33d530..44bafdd 100644
--- a/arch/x86/kernel/asm-offsets_32.c
+++ b/arch/x86/kernel/asm-offsets_32.c
@@ -134,7 +134,7 @@ void foo(void)
 	OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
 #endif
 
-#ifdef CONFIG_LGUEST
+#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
 	BLANK();
 	OFFSET(LGUEST_PAGES_host_gdt_desc, lguest_pages, state.host_gdt_desc);
 	OFFSET(LGUEST_PAGES_host_idt_desc, lguest_pages, state.host_idt_desc);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lguest: fix undefined asm-offsets symbols
  2008-02-20 20:21 [PATCH] lguest: fix undefined asm-offsets symbols Kyle McMartin
@ 2008-03-04  0:14 ` Rusty Russell
  0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2008-03-04  0:14 UTC (permalink / raw)
  To: Kyle McMartin; +Cc: linux-kernel, lguest, fedora-kernel-list

On Thursday 21 February 2008 07:21:52 Kyle McMartin wrote:
> lguest uses asm-offsets to generate ... offsets, obviously, for use
> in the lguest switcher code. When the hypervisor code is built as a
> module though, the asm offsets it needs won't be generated since
> CONFIG_LGUEST will be undefined.
>
> Signed-off-by: Kyle McMartin <kmcmartin@redhat.com>

Thanks Kyle,

   This is in Linus' tree now thanks to Ingo.  I had a slightly different fix 
which I mistakenly hadn't pushed, but this works fine.

Cheers,
Rusty.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-04  0:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-20 20:21 [PATCH] lguest: fix undefined asm-offsets symbols Kyle McMartin
2008-03-04  0:14 ` Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).