LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mark Lord <mlord@pobox.com>, Jeff Garzik <jeff@garzik.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [ata crash] Re: Linux 2.6.25-rc1
Date: Thu, 21 Feb 2008 08:12:53 +0100	[thread overview]
Message-ID: <20080221071253.GB13694@elte.hu> (raw)
In-Reply-To: <47BCE2F5.6020305@gmail.com>


* Tejun Heo <htejun@gmail.com> wrote:

> Tejun Heo wrote:
> > Ingo Molnar wrote:
> >> On a second attempt to boot the same bzImage, another ATA related 
> >> weirdness showed up:
> >>
> >> [    8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
> >> [    8.232017] Bad IO access at port 0x0 (outb(val,port))
> >> [    8.232799] ------------[ cut here ]------------
> >> [    8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
> >> [    8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
> >> [    8.232799]  [<c011fd63>] warn_on_slowpath+0x3c/0x4c
> >> [    8.232799]  [<c0358e9d>] ? serial8250_console_write+0x0/0x14e
> >> [    8.232799]  [<c01200a5>] ? __call_console_drivers+0x56/0x63
> >> [    8.232799]  [<c06b7acf>] ? _spin_unlock_irqrestore+0x15/0x21
> >> [    8.232799]  [<c0120556>] ? release_console_sem+0x1c1/0x1c9
> >> [    8.232799]  [<c015c400>] ? print_trailer+0x6e/0xfc
> >> [    8.232799]  [<c015c77f>] ? check_object+0x10b/0x181
> >> [    8.232799]  [<c01209a0>] ? printk+0x15/0x17
> >> [    8.232799]  [<c02cc2ce>] bad_io_access+0x2f/0x34
> >> [    8.232799]  [<c02cc48a>] iowrite8+0x31/0x34
> >> [    8.232799]  [<c04a1c8d>] ata_bmdma_freeze+0x1d/0x30
> >> [    8.232799]  [<c04a2063>] __ata_port_freeze+0x2c/0x33
> >> [    8.232799]  [<c04a224f>] ata_eh_freeze_port+0x21/0x2f
> >> [    8.232799]  [<c0497fa9>] ata_host_start+0xe1/0x132
> > 
> > Does the following patch fix the above problem?  pata_isapnp is the
> > only one which can have NULL ctl_addr and libata SFF layer wasn't
> > ready for that.
> 
> Ping.

Pong. Please consider it fixed and merge the fix upstream - i havent 
seen these problems since i put your fix into my qa tree (and forgot 
about it completely). If there's any problem left i'll follow up on it. 
(For the record, the patch below is the one i tested with various x86 
hardware.)

	Ingo

------------->
Subject: Re: Re: Linux 2.6.25-rc1
From: Tejun Heo <htejun@gmail.com>
Date: Wed, 13 Feb 2008 18:51:39 +0900

Ingo Molnar wrote:
> On a second attempt to boot the same bzImage, another ATA related
> weirdness showed up:
>
> [    8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
> [    8.232017] Bad IO access at port 0x0 (outb(val,port))
> [    8.232799] ------------[ cut here ]------------
> [    8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
> [    8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
> [    8.232799]  [<c011fd63>] warn_on_slowpath+0x3c/0x4c
> [    8.232799]  [<c0358e9d>] ? serial8250_console_write+0x0/0x14e
> [    8.232799]  [<c01200a5>] ? __call_console_drivers+0x56/0x63
> [    8.232799]  [<c06b7acf>] ? _spin_unlock_irqrestore+0x15/0x21
> [    8.232799]  [<c0120556>] ? release_console_sem+0x1c1/0x1c9
> [    8.232799]  [<c015c400>] ? print_trailer+0x6e/0xfc
> [    8.232799]  [<c015c77f>] ? check_object+0x10b/0x181
> [    8.232799]  [<c01209a0>] ? printk+0x15/0x17
> [    8.232799]  [<c02cc2ce>] bad_io_access+0x2f/0x34
> [    8.232799]  [<c02cc48a>] iowrite8+0x31/0x34
> [    8.232799]  [<c04a1c8d>] ata_bmdma_freeze+0x1d/0x30
> [    8.232799]  [<c04a2063>] __ata_port_freeze+0x2c/0x33
> [    8.232799]  [<c04a224f>] ata_eh_freeze_port+0x21/0x2f
> [    8.232799]  [<c0497fa9>] ata_host_start+0xe1/0x132

Does the following patch fix the above problem?  pata_isapnp is the
only one which can have NULL ctl_addr and libata SFF layer wasn't
ready for that.

Thanks.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/ata/libata-eh.c  |   10 ++++++++++
 drivers/ata/libata-sff.c |   22 ++++++++++++++--------
 2 files changed, 24 insertions(+), 8 deletions(-)

Index: linux/drivers/ata/libata-eh.c
===================================================================
--- linux.orig/drivers/ata/libata-eh.c
+++ linux/drivers/ata/libata-eh.c
@@ -2150,6 +2150,15 @@ int ata_eh_reset(struct ata_link *link, 
 			ap->ops->set_piomode(ap, dev);
 	}
 
+	if (!softreset && !hardreset) {
+		if (verbose)
+			ata_link_printk(link, KERN_INFO, "no reset method "
+					"available, skipping reset\n");
+		if (!(lflags & ATA_LFLAG_ASSUME_CLASS))
+			lflags |= ATA_LFLAG_ASSUME_ATA;
+		goto done;
+	}
+
 	/* Determine which reset to use and record in ehc->i.action.
 	 * prereset() may examine and modify it.
 	 */
@@ -2254,6 +2263,7 @@ int ata_eh_reset(struct ata_link *link, 
 		lflags |= ATA_LFLAG_ASSUME_ATA;
 	}
 
+ done:
 	ata_link_for_each_dev(dev, link) {
 		/* After the reset, the device state is PIO 0 and the
 		 * controller state is undefined.  Reset also wakes up
Index: linux/drivers/ata/libata-sff.c
===================================================================
--- linux.orig/drivers/ata/libata-sff.c
+++ linux/drivers/ata/libata-sff.c
@@ -56,7 +56,8 @@ u8 ata_irq_on(struct ata_port *ap)
 	ap->ctl &= ~ATA_NIEN;
 	ap->last_ctl = ap->ctl;
 
-	iowrite8(ap->ctl, ioaddr->ctl_addr);
+	if (ioaddr->ctl_addr)
+		iowrite8(ap->ctl, ioaddr->ctl_addr);
 	tmp = ata_wait_idle(ap);
 
 	ap->ops->irq_clear(ap);
@@ -81,7 +82,8 @@ void ata_tf_load(struct ata_port *ap, co
 	unsigned int is_addr = tf->flags & ATA_TFLAG_ISADDR;
 
 	if (tf->ctl != ap->last_ctl) {
-		iowrite8(tf->ctl, ioaddr->ctl_addr);
+		if (ioaddr->ctl_addr)
+			iowrite8(tf->ctl, ioaddr->ctl_addr);
 		ap->last_ctl = tf->ctl;
 		ata_wait_idle(ap);
 	}
@@ -167,13 +169,15 @@ void ata_tf_read(struct ata_port *ap, st
 	tf->device = ioread8(ioaddr->device_addr);
 
 	if (tf->flags & ATA_TFLAG_LBA48) {
-		iowrite8(tf->ctl | ATA_HOB, ioaddr->ctl_addr);
+		if (ioaddr->ctl_addr)
+			iowrite8(tf->ctl | ATA_HOB, ioaddr->ctl_addr);
 		tf->hob_feature = ioread8(ioaddr->error_addr);
 		tf->hob_nsect = ioread8(ioaddr->nsect_addr);
 		tf->hob_lbal = ioread8(ioaddr->lbal_addr);
 		tf->hob_lbam = ioread8(ioaddr->lbam_addr);
 		tf->hob_lbah = ioread8(ioaddr->lbah_addr);
-		iowrite8(tf->ctl, ioaddr->ctl_addr);
+		if (ioaddr->ctl_addr)
+			iowrite8(tf->ctl, ioaddr->ctl_addr);
 		ap->last_ctl = tf->ctl;
 	}
 }
@@ -352,7 +356,8 @@ void ata_bmdma_freeze(struct ata_port *a
 	ap->ctl |= ATA_NIEN;
 	ap->last_ctl = ap->ctl;
 
-	iowrite8(ap->ctl, ioaddr->ctl_addr);
+	if (ioaddr->ctl_addr)
+		iowrite8(ap->ctl, ioaddr->ctl_addr);
 
 	/* Under certain circumstances, some controllers raise IRQ on
 	 * ATA_NIEN manipulation.  Also, many controllers fail to mask
@@ -459,13 +464,14 @@ void ata_bmdma_drive_eh(struct ata_port 
  */
 void ata_bmdma_error_handler(struct ata_port *ap)
 {
-	ata_reset_fn_t hardreset;
+	ata_reset_fn_t softreset = NULL, hardreset = NULL;
 
-	hardreset = NULL;
+	if (ap->ioaddr.ctl_addr)
+		softreset = ata_std_softreset;
 	if (sata_scr_valid(&ap->link))
 		hardreset = sata_std_hardreset;
 
-	ata_bmdma_drive_eh(ap, ata_std_prereset, ata_std_softreset, hardreset,
+	ata_bmdma_drive_eh(ap, ata_std_prereset, softreset, hardreset,
 			   ata_std_postreset);
 }
 

      reply	other threads:[~2008-02-21  7:13 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  0:44 Linus Torvalds
2008-02-11  1:36 ` Sergio Luis
2008-02-11  1:47 ` Linux 2.6.25-rc1 , syntax error near unexpected token `;' Mr. James W. Laferriere
2008-02-11  7:02   ` Ray Lee
2008-02-11 13:29     ` [patch] " Oleg Verych
2008-02-11 13:26   ` Sam Ravnborg
2008-02-12  3:37     ` Mr. James W. Laferriere
2008-02-11  3:14 ` Linux 2.6.25-rc1 Gene Heskett
2008-02-11  7:39 ` Brice Goglin
2008-02-11 15:16   ` Arjan van de Ven
2008-02-11 11:19 ` parisc - error: 'VMALLOC_START' undeclared Domenico Andreoli
2008-02-11 12:06   ` Adrian Bunk
2008-02-11 13:31 ` Linux 2.6.25-rc1 Sam Ravnborg
2008-02-11 16:17   ` Mike Frysinger
2008-02-11 16:47   ` [PATCH] kbuild: fix make V=1 Sam Ravnborg
2008-02-11 23:38     ` Oleg Verych
2008-02-12  8:56       ` Sam Ravnborg
2008-02-12  9:25         ` Oleg Verych
2008-02-12 15:07           ` Mike Frysinger
2008-02-12 15:49             ` Oleg Verych
2008-02-12 16:18               ` Mike Frysinger
2008-02-12 16:42                 ` Oleg Verych
2008-02-12 20:01           ` Sam Ravnborg
2008-02-11 21:46 ` Linux 2.6.25-rc1 Torsten Kaiser
2008-02-11 22:15   ` Andrew Morton
2008-02-11 22:48     ` Stefan Richter
2008-02-13 19:17     ` Torsten Kaiser
2008-02-12  8:18 ` [ata crash] " Ingo Molnar
2008-02-12 15:14   ` Arjan van de Ven
2008-02-13  9:01     ` Ingo Molnar
2008-02-13  9:20       ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Tejun Heo
2008-02-13  9:24         ` Ingo Molnar
2008-02-15 18:52         ` Jeff Garzik
2008-02-13  9:51   ` [ata crash] Re: Linux 2.6.25-rc1 Tejun Heo
2008-02-21  2:33     ` Tejun Heo
2008-02-21  7:12       ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080221071253.GB13694@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlord@pobox.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [ata crash] Re: Linux 2.6.25-rc1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).