LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH] viocons: BKL locking
Date: Thu, 21 Feb 2008 10:50:56 +0000	[thread overview]
Message-ID: <20080221105056.69e6678c@core> (raw)
In-Reply-To: <18364.63205.933131.746580@cargo.ozlabs.ibm.com>

On Thu, 21 Feb 2008 14:58:29 +1100
Paul Mackerras <paulus@samba.org> wrote:

> Alan Cox writes:
> 
> > For some weird reason I can't ascertain (translation "I think its
> > broken") the viocons driver calls directly into the n_tty ldisc code even
> > if another ldisc is in use. It'll probably break if you do that but I'm
> > just fixing the locking and adding a comment that its horked.
> 
> Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead
> of calling n_tty_ioctl -- do you agree?

I think that is probably what is intended. That would then bounce back
throuh the tty layer to the right places.

Alan

  reply	other threads:[~2008-02-21 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 20:32 Alan Cox
2008-02-21  3:58 ` Paul Mackerras
2008-02-21 10:50   ` Alan Cox [this message]
2008-02-21 11:10     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080221105056.69e6678c@core \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: [PATCH] viocons: BKL locking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).