LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c
@ 2008-02-22 22:11 Paolo Ciarrocchi
2008-02-22 22:43 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Ciarrocchi @ 2008-02-22 22:11 UTC (permalink / raw)
To: hpa, Ingo Molnar, tglx; +Cc: Linux Kernel
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
arch/x86/xen/multicalls.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index 5e6f36f..5791eb2 100644
--- a/arch/x86/xen/multicalls.c
+++ b/arch/x86/xen/multicalls.c
@@ -76,7 +76,7 @@ void xen_mc_flush(void)
if (ret) {
printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
ret, smp_processor_id());
- for(i = 0; i < b->mcidx; i++) {
+ for (i = 0; i < b->mcidx; i++) {
printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
i+1, b->mcidx,
b->debug[i].op,
@@ -93,7 +93,7 @@ void xen_mc_flush(void)
local_irq_restore(flags);
- for(i = 0; i < b->cbidx; i++) {
+ for (i = 0; i < b->cbidx; i++) {
struct callback *cb = &b->callbacks[i];
(*cb->fn)(cb->data);
--
1.5.4.GIT
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c
2008-02-22 22:11 [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c Paolo Ciarrocchi
@ 2008-02-22 22:43 ` Joe Perches
2008-02-23 10:01 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2008-02-22 22:43 UTC (permalink / raw)
To: Paolo Ciarrocchi; +Cc: hpa, Ingo Molnar, tglx, Linux Kernel
On Fri, 2008-02-22 at 23:11 +0100, Paolo Ciarrocchi wrote:
> File is now error free.
> Compile tested.
>
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
> ---
> arch/x86/xen/multicalls.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
> index 5e6f36f..5791eb2 100644
> --- a/arch/x86/xen/multicalls.c
> +++ b/arch/x86/xen/multicalls.c
> @@ -76,7 +76,7 @@ void xen_mc_flush(void)
> if (ret) {
> printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> ret, smp_processor_id());
> - for(i = 0; i < b->mcidx; i++) {
> + for (i = 0; i < b->mcidx; i++) {
> printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
The printk needs a KERN_ERR prefix
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c
2008-02-22 22:43 ` Joe Perches
@ 2008-02-23 10:01 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-02-23 10:01 UTC (permalink / raw)
To: Joe Perches; +Cc: Paolo Ciarrocchi, hpa, tglx, Linux Kernel
* Joe Perches <joe@perches.com> wrote:
> > printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> > ret, smp_processor_id());
> > - for(i = 0; i < b->mcidx; i++) {
> > + for (i = 0; i < b->mcidx; i++) {
> > printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
>
> The printk needs a KERN_ERR prefix
yes - but we prefer to isolate the "does not change the .o in any way"
cleanups from cleanups that materially change kernel behavior. (such as
printing something else)
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-23 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-22 22:11 [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c Paolo Ciarrocchi
2008-02-22 22:43 ` Joe Perches
2008-02-23 10:01 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).