LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Menage <menage@google.com>
Cc: pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Cpusets API: Update cpusets to use cgroup structured file API
Date: Sat, 23 Feb 2008 00:06:31 -0800	[thread overview]
Message-ID: <20080223000631.f4c1dbf4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080220050032.396158000@menage.corp.google.com>

On Tue, 19 Feb 2008 20:54:10 -0800 Paul Menage <menage@google.com> wrote:

> Many of the cpusets control files are simple integer values, which
> don't require the overhead of memory allocations for reads and writes.
> 
> Move the handlers for these control files into cpuset_read_uint() and
> cpuset_write_uint(). This also has the advantage that the control
> files show up as "u64" rather than "string" in the cgroup.api file.

again, the naming here is a bit misleading - s/uint/u64/ would be clearer.

It is unclear to me what the relationship is between this and your other
cgroup pseudo-fs changes, but as this is fiddling with a userspace
interface we should get a wiggle on - we don't want to let things like this
slip out to 2.6.26.

So..  please resend everything?

  reply	other threads:[~2008-02-23  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20  4:54 [PATCH 0/2] Cpusets API: Update Cpusets control files Paul Menage
2008-02-20  4:54 ` [PATCH 1/2] Cpusets API: From: Paul Jackson <pj@sgi.com> Paul Menage
2008-02-20  4:54 ` [PATCH 2/2] Cpusets API: Update cpusets to use cgroup structured file API Paul Menage
2008-02-23  8:06   ` Andrew Morton [this message]
2008-02-23 15:28     ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080223000631.f4c1dbf4.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=pj@sgi.com \
    --subject='Re: [PATCH 2/2] Cpusets API: Update cpusets to use cgroup structured file API' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).