LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] make c_idle.work have a static address.
@ 2008-02-22 15:09 Glauber Costa
  2008-02-23 10:27 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Glauber Costa @ 2008-02-22 15:09 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, glommer, mingo, pzijlstr, arjan, Glauber Costa

Currently, c_idle is declared in the stack, and thus, have no static address.

Peter Zijlstra points out this simple solution, in which c_idle.work
is initializated separatedly. Note that the INIT_WORK macro has a static
declaration of a key inside.

Signed-off-by: Glauber Costa <gcosta@redhat.com>
CC: Peter Zijlstra <pzijlstr@redhat.com>
---
 arch/x86/kernel/smpboot_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index d53bd6f..0880f2c 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -554,10 +554,10 @@ static int __cpuinit do_boot_cpu(int cpu
 	int timeout;
 	unsigned long start_rip;
 	struct create_idle c_idle = {
-		.work = __WORK_INITIALIZER(c_idle.work, do_fork_idle),
 		.cpu = cpu,
 		.done = COMPLETION_INITIALIZER_ONSTACK(c_idle.done),
 	};
+	INIT_WORK(&c_idle.work, do_fork_idle);
 
 	/* allocate memory for gdts of secondary cpus. Hotplug is considered */
 	if (!cpu_gdt_descr[cpu].address &&
-- 
1.4.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] make c_idle.work have a static address.
  2008-02-22 15:09 [PATCH] make c_idle.work have a static address Glauber Costa
@ 2008-02-23 10:27 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-23 10:27 UTC (permalink / raw)
  To: Glauber Costa; +Cc: linux-kernel, akpm, glommer, pzijlstr, arjan


* Glauber Costa <gcosta@redhat.com> wrote:

> Currently, c_idle is declared in the stack, and thus, have no static 
> address.
> 
> Peter Zijlstra points out this simple solution, in which c_idle.work 
> is initializated separatedly. Note that the INIT_WORK macro has a 
> static declaration of a key inside.

thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-23 10:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-22 15:09 [PATCH] make c_idle.work have a static address Glauber Costa
2008-02-23 10:27 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).