LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 1/3] IDE: Coding Style fixes to drivers/ide/ide-cd.c
Date: Sun, 24 Feb 2008 23:56:45 +0200	[thread overview]
Message-ID: <20080224215645.GE1596@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080224221033.595552ce@paolo-desktop>

On Sun, Feb 24, 2008 at 10:10:33PM +0100, Paolo Ciarrocchi wrote:
> Before:
> total: 43 errors, 66 warnings, 2183 lines checked
> 
> After:
> total: 0 errors, 36 warnings, 2192 lines checked
> 
> I didn't (and I don't plan to) fix the warnings:
> WARNING: line over 80 characters
> 
> 
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
> ---
>  drivers/ide/ide-cd.c |  245 ++++++++++++++++++++++++++------------------------
>  1 files changed, 127 insertions(+), 118 deletions(-)
> 
> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 546f436..3181e71 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
>...
>  	switch (sense->sense_key) {
> -		case NO_SENSE: case RECOVERED_ERROR:
> -			break;
>...
> +	case NO_SENSE: case RECOVERED_ERROR:
> +		break;
>...

In case the goal is not to only improve the checkpatch metrics but to 
improve the readability of the code the biggest coding style problem 
here was (and still is) not the indentation.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2008-02-24 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 21:10 Paolo Ciarrocchi
2008-02-24 21:56 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080224215645.GE1596@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    --subject='Re: [PATCH 1/3] IDE: Coding Style fixes to drivers/ide/ide-cd.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).