LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
@ 2008-02-25  0:08 Adrian Bunk
  0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-02-25  0:08 UTC (permalink / raw)
  To: linux-kernel

Every file should include the headers containing the externs for its 
global code (in this case for struct generic_file_vm_ops).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c b/mm/filemap.c
index 5c74b68..9b58ae0 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -34,6 +34,8 @@
 #include <linux/cpuset.h>
 #include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
 #include <linux/memcontrol.h>
+#include <linux/ramfs.h>
+
 #include "internal.h"
 
 /*


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
  2008-05-05 18:27 Adrian Bunk
@ 2008-05-05 18:46 ` Christoph Hellwig
  0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2008-05-05 18:46 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel, Andrew Morton

On Mon, May 05, 2008 at 09:27:50PM +0300, Adrian Bunk wrote:
> Every file should include the headers containing the externs for its 
> global code (in this case for struct generic_file_vm_ops).

Please move generic_file_vm_ops to fs.h instead please, it doesn't
belong into a fle called ramfs.h, and neither should filemap.c include
such a header.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
@ 2008-05-05 18:27 Adrian Bunk
  2008-05-05 18:46 ` Christoph Hellwig
  0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2008-05-05 18:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Every file should include the headers containing the externs for its 
global code (in this case for struct generic_file_vm_ops).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 22 Apr 2008
- 14 Apr 2008
- 31 Mar 2008
- 25 Feb 2008

31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c b/mm/filemap.c
index 5c74b68..9b58ae0 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -34,6 +34,8 @@
 #include <linux/cpuset.h>
 #include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
 #include <linux/memcontrol.h>
+#include <linux/ramfs.h>
+
 #include "internal.h"
 
 /*


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
@ 2008-04-21 21:32 Adrian Bunk
  0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-04-21 21:32 UTC (permalink / raw)
  To: linux-kernel

Every file should include the headers containing the externs for its 
global code (in this case for struct generic_file_vm_ops).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 14 Apr 2008
- 31 Mar 2008
- 25 Feb 2008

31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c b/mm/filemap.c
index 5c74b68..9b58ae0 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -34,6 +34,8 @@
 #include <linux/cpuset.h>
 #include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
 #include <linux/memcontrol.h>
+#include <linux/ramfs.h>
+
 #include "internal.h"
 
 /*


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
@ 2008-04-14 18:14 Adrian Bunk
  0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-04-14 18:14 UTC (permalink / raw)
  To: linux-kernel

Every file should include the headers containing the externs for its 
global code (in this case for struct generic_file_vm_ops).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 31 Mar 2008
- 25 Feb 2008

31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c b/mm/filemap.c
index 5c74b68..9b58ae0 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -34,6 +34,8 @@
 #include <linux/cpuset.h>
 #include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
 #include <linux/memcontrol.h>
+#include <linux/ramfs.h>
+
 #include "internal.h"
 
 /*


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
@ 2008-03-30 22:49 Adrian Bunk
  0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-03-30 22:49 UTC (permalink / raw)
  To: linux-kernel

Every file should include the headers containing the externs for its 
global code (in this case for struct generic_file_vm_ops).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 25 Feb 2008

31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c b/mm/filemap.c
index 5c74b68..9b58ae0 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -34,6 +34,8 @@
 #include <linux/cpuset.h>
 #include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
 #include <linux/memcontrol.h>
+#include <linux/ramfs.h>
+
 #include "internal.h"
 
 /*


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-05-05 18:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-25  0:08 [2.6 patch] mm/filemap.c should #include <linux/ramfs.h> Adrian Bunk
2008-03-30 22:49 Adrian Bunk
2008-04-14 18:14 Adrian Bunk
2008-04-21 21:32 Adrian Bunk
2008-05-05 18:27 Adrian Bunk
2008-05-05 18:46 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).