LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "S.Çağlar Onur" <caglar@pardus.org.tr>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kmcmartin@redhat.com, lguest@ozlabs.org, rusty@rustcorp.com.au
Subject: Re: Linux 2.6.25-rc3
Date: Mon, 25 Feb 2008 01:29:15 +0200	[thread overview]
Message-ID: <200802250129.17526.caglar@pardus.org.tr> (raw)
In-Reply-To: <alpine.LFD.1.00.0802241354200.14934@woody.linux-foundation.org>

Hi;

25 Şub 2008 Pts tarihinde, Linus Torvalds şunları yazmıştı: 
> 
> Ok, it's out there, ready for your enjoyment.
[...] 
> So give it a good testing, please,

-rc3 still fails for this [1] config

ERROR: "LGUEST_PAGES_guest_gdt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_gdt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_cr3" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_regs" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_idt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_guest_gdt" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_sp" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_regs_trapnum" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_guest_idt_desc" [drivers/lguest/lg.ko] undefined!

and following patch by Kyle McMartin solves this issue, this patch posted on 20 Feb to LKML but not CC'd to you.

From: Kyle McMartin <kyle@mcmartin.ca>

lguest uses asm-offsets to generate ... offsets, obviously, for use
in the lguest switcher code. When the hypervisor code is built as a
module though, the asm offsets it needs won't be generated since
CONFIG_LGUEST will be undefined.

Signed-off-by: Kyle McMartin <kmcmartin@redhat.com>

---
diff --git a/arch/x86/kernel/asm-offsets_32.c b/arch/x86/kernel/asm-offsets_32.c
index a33d530..44bafdd 100644
--- a/arch/x86/kernel/asm-offsets_32.c
+++ b/arch/x86/kernel/asm-offsets_32.c
@@ -134,7 +134,7 @@ void foo(void)
        OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
 #endif
 
-#ifdef CONFIG_LGUEST
+#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
        BLANK();
        OFFSET(LGUEST_PAGES_host_gdt_desc, lguest_pages, state.host_gdt_desc);
        OFFSET(LGUEST_PAGES_host_idt_desc, lguest_pages, state.host_idt_desc);


[1] http://cekirdek.pardus.org.tr/~caglar/config.2.6.25-rc3
Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

  reply	other threads:[~2008-02-24 23:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 22:16 Linus Torvalds
2008-02-24 23:29 ` S.Çağlar Onur [this message]
2008-02-25  7:16   ` Ingo Molnar
2008-02-27 16:12     ` Kyle McMartin
2008-02-27 16:16       ` Ingo Molnar
2008-02-27 16:39         ` Kyle McMartin
2008-02-26 14:29 ` [BUILD_FAILURE] Linux 2.6.25-rc3 - various unexported functions () on powerpc Kamalesh Babulal
2008-02-26 15:15   ` Adrian Bunk
2008-02-26 18:18     ` Kamalesh Babulal
2008-02-26 18:25       ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802250129.17526.caglar@pardus.org.tr \
    --to=caglar@pardus.org.tr \
    --cc=kmcmartin@redhat.com \
    --cc=lguest@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Linux 2.6.25-rc3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).