LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Kevin Winchester <kjwinchester@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	len.brown@intel.com, linux-pm@lists.linux-foundation.org,
	Ingo Molnar <mingo@elte.hu>,
	peterz@infradead.org
Subject: Re: linux-next: Tree for Feb 24
Date: Mon, 25 Feb 2008 10:26:28 +0100	[thread overview]
Message-ID: <20080225092628.GA493@elf.ucw.cz> (raw)
In-Reply-To: <47C1FF2E.4060600@gmail.com>

Hi!

> > velocity_suspend() seems to be at fault.
> 
> (gdb) l *(velocity_suspend+0x37)
> 0xc0244665 is in velocity_suspend (drivers/net/via-velocity.c:3399).
> 3394		if(!netif_running(vptr->dev))
> 3395			return 0;
> 3396	
> 3397		netif_device_detach(vptr->dev);
> 3398	
> 3399		spin_lock_irqsave(&vptr->lock, flags);
> 3400		pci_save_state(pdev);
> 3401	#ifdef ETHTOOL_GWOL
> 3402		if (vptr->flags & VELOCITY_FLAGS_WOL_ENABLED) {
> 3403			velocity_get_ip(vptr);
> (gdb) 
> 3404			velocity_save_context(vptr, &vptr->context);
> 3405			velocity_shutdown(vptr);
> 3406			velocity_set_wol(vptr);
> 3407			pci_enable_wake(pdev, PCI_D3hot, 1);
> 3408			pci_set_power_state(pdev, PCI_D3hot);
> 3409		} else {
> 3410			velocity_save_context(vptr, &vptr->context);
> 3411			velocity_shutdown(vptr);
> 3412			pci_disable_device(pdev);
> 3413			pci_set_power_state(pdev, pci_choose_state(pdev, state));
> (gdb) 
> 3414		}
> 3415	#else
> 3416		pci_set_power_state(pdev, pci_choose_state(pdev, state));
> 3417	#endif
> 3418		spin_unlock_irqrestore(&vptr->lock, flags);
> 3419		return 0;
> 3420	}
> 
> So velocity_suspend calls spin_lock_irqsave, and then pci_set_power_state which msleep()s.  Is that the root problem here? (I've added Ingo & Peter to the CC list since they may have some comments on the scheduler/lockdep parts of the trace).

Looks like velocity is broken. Can you try to unload it before sleep
to see if the rest of suspend works for you?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2008-02-25 11:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24  5:23 Stephen Rothwell
2008-02-24 18:19 ` Kevin Winchester
2008-02-24 20:00   ` Rafael J. Wysocki
2008-02-24 23:35     ` Kevin Winchester
2008-02-24 23:43       ` Rafael J. Wysocki
2008-02-25  0:23         ` Kevin Winchester
2008-02-25  9:26       ` Pavel Machek [this message]
2008-02-26  0:24         ` broken suspend to ram with velocity driver Kevin Winchester
2008-02-26  0:49           ` Rafael J. Wysocki
2008-02-27  0:36             ` Kevin Winchester
2008-02-27 12:59               ` Rafael J. Wysocki
2008-02-27  0:48             ` Kevin Winchester
2008-02-27 13:00               ` Rafael J. Wysocki
2008-02-26 21:49           ` Pavel Machek
2008-02-27  0:28             ` Kevin Winchester
2008-02-27 13:06               ` Rafael J. Wysocki
2008-02-27 13:08               ` Matthew Garrett
2008-02-25 21:56 ` linux-next: Tree for Feb 24 Geert Uytterhoeven
2008-02-25 22:30   ` Randy Dunlap
2008-02-25 23:49   ` Stephen Rothwell
2008-02-26  7:55     ` Geert Uytterhoeven
2008-02-25  6:31 Stephen Rothwell
2008-02-25 10:12 ` Frank Seidel
2008-02-25 11:11   ` Stephen Rothwell
2012-02-24  6:05 Stephen Rothwell
2013-02-26  3:16 Stephen Rothwell
2013-02-26  5:00 ` Sedat Dilek
2013-02-26  5:30   ` Stephen Rothwell
2014-02-24  6:37 Stephen Rothwell
2015-02-24  3:02 Stephen Rothwell
2016-02-24  5:34 Stephen Rothwell
2016-02-24  6:32 ` Sedat Dilek
2016-02-24 14:37   ` Benjamin LaHaise
2016-03-17 10:21     ` Sedat Dilek
2016-03-17 10:27       ` Stephen Rothwell
2016-03-17 10:37         ` Sedat Dilek
2017-02-24  3:01 Stephen Rothwell
2020-02-24  4:32 Stephen Rothwell
2021-02-24  3:36 Stephen Rothwell
2022-02-25  2:16 broonie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080225092628.GA493@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=kjwinchester@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: linux-next: Tree for Feb 24' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).