LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: jgarzik@pobox.com, Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: [PATCH] de2104x: remove BUG_ON() when changing media type
Date: Mon, 25 Feb 2008 18:45:46 +0100 [thread overview]
Message-ID: <200802251845.51562.linux@rainbow-software.org> (raw)
In-Reply-To: <20080225071505.GC26674@colo.lackof.org>
When the chip dies (probably because of a bug somewhere in the driver),
de_stop_rxtx() fails and changing the media type crashes the whole machine.
Replace BUG_ON() in de_set_media() with a warning.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- linux-2.6.24-orig/drivers/net/tulip/de2104x.c 2008-02-25 18:27:34.000000000 +0100
+++ linux-2.6.24-pentium/drivers/net/tulip/de2104x.c 2008-02-25 18:34:56.000000000 +0100
@@ -910,7 +910,8 @@
unsigned media = de->media_type;
u32 macmode = dr32(MacMode);
- BUG_ON(de_is_running(de));
+ if (de_is_running(de))
+ printk(KERN_WARNING "%s: chip is running while changing media!\n", de->dev->name);
if (de->de21040)
dw32(CSR11, FULL_DUPLEX_MAGIC);
--
Ondrej Zary
next prev parent reply other threads:[~2008-02-25 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 20:58 Compex FreedomLine 32 PnP-PCI2 broken with de2104x Ondrej Zary
2008-01-30 20:23 ` Ondrej Zary
2008-02-18 3:21 ` Grant Grundler
2008-02-18 16:40 ` Ondrej Zary
2008-02-25 7:15 ` Grant Grundler
2008-02-25 7:30 ` Jeff Garzik
2008-02-26 7:48 ` Grant Grundler
2008-02-25 17:45 ` Ondrej Zary [this message]
2008-02-25 17:52 ` [PATCH] de2104x: remove BUG_ON() when changing media type Jeff Garzik
2008-03-24 2:45 ` Grant Grundler
2008-03-24 23:02 ` Ondrej Zary
2008-03-26 15:59 ` Grant Grundler
2008-03-26 18:29 ` Ondrej Zary
2008-03-05 11:27 ` Jeff Garzik
2008-02-25 7:28 ` Compex FreedomLine 32 PnP-PCI2 broken with de2104x Jeff Garzik
2008-02-25 21:31 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802251845.51562.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=grundler@parisc-linux.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH] de2104x: remove BUG_ON() when changing media type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).