LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Michael S. Tsirkin" <m.s.tsirkin@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Alexey Starikovskiy" <astarikovskiy@suse.de>,
	"Len Brown" <len.brown@intel.com>,
	linux-acpi@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
	Jeff Garzik <jeff@garzik.org>
Subject: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Date: Mon, 25 Feb 2008 21:57:09 +0100	[thread overview]
Message-ID: <200802252157.10412.rjw@sisk.pl> (raw)
In-Reply-To: <8f53421d0802251245j5439b37die840e34bb293f995@mail.gmail.com>

On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
> On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <m.s.tsirkin@gmail.com> wrote:
> >
> >  > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses
> >  > such as Fn-F4 and lid open/close, prints them in /var/log/acpid
> >  > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4).
> >
> >  You mean suspend-to-ram works correctly on your t61p?
> >
> >  Mine suspends, then five seconds later magically resumes itself and the
> >  screen is all black.
> 
> Sorry, have not noticed what you were asking about.
> Yes, rc2 seems to suspend/resume fine.
> 
> And after reverting
> 
>      revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.

commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek <pavel@ucw.cz>
Date:   Thu Feb 21 13:56:55 2008 +0100

    power_state: get rid of write-only variable in SATA

>      revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e.

commit 208c70a45624400fafd7511b96bc426bf01f8f5e
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Thu Feb 14 15:58:47 2008 -0500

    ACPI: EC: Use proper handle for boot EC

> r3 does, too.

Please, _please_ always add commit subjects to your reports.  Also, please
include the names of the authors of the commits that turn out to break things
and send CCs to them.

It won't hurt to send CCs to the people who signed those commits off, too.

Thanks,
Rafael

  reply	other threads:[~2008-02-25 20:58 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 19:19 new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Michael S. Tsirkin
2008-02-25 19:42 ` Alexey Starikovskiy
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:50     ` Alexey Starikovskiy
2008-02-25 21:01       ` Michael S. Tsirkin
2008-02-25 22:33         ` Alexey Starikovskiy
2008-02-25 23:18           ` Michael S. Tsirkin
2008-02-25 19:46 ` Andrew Morton
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:45   ` Michael S. Tsirkin
2008-02-25 20:57     ` Rafael J. Wysocki [this message]
2008-02-25 21:26       ` broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) Pavel Machek
2008-02-25 21:31         ` Michael S. Tsirkin
2008-02-25 21:50           ` Pavel Machek
2008-02-25 22:15             ` Michael S. Tsirkin
2008-02-25 22:20               ` Pavel Machek
2008-02-25 22:36                 ` Michael S. Tsirkin
2008-02-25 22:39                   ` Andrew Morton
2008-02-25 22:48                     ` Michael S. Tsirkin
2008-02-25 22:53                       ` Andrew Morton
2008-02-25 22:58                         ` Michael S. Tsirkin
2008-02-25 22:58                         ` Pavel Machek
     [not found]                           ` <20080225155550.4a020dfb.akpm@linux-foundation.org>
     [not found]                             ` <20080226000007.GB22102@atrey.karlin.mff.cuni.cz>
2008-02-26 10:11                               ` Pavel Machek
2008-02-26 17:46                                 ` Dave Jones
2008-02-26 17:59                                   ` Pavel Machek
2008-02-26 18:10                                     ` Dave Jones
2008-02-26 18:16                                       ` Pavel Machek
2008-02-26 18:22                                         ` Dave Jones
2008-02-26 21:56                                           ` Pavel Machek
2008-02-26 22:23                                             ` Dave Jones
2008-02-26 22:31                                               ` Rafael J. Wysocki
2008-02-26 22:51                                               ` Pavel Machek
2008-02-27 13:12                                             ` Matthew Garrett
2008-02-27 13:23                                               ` Rafael J. Wysocki
2008-02-27 15:51                                                 ` Stefan Seyfried
2008-02-27 15:55                                                   ` Matthew Garrett
2008-02-26 18:56                                         ` Andrew Morton
2008-02-26 20:09                                           ` Len Brown
2008-02-26 23:31                                           ` Ray Lee
2008-02-27  0:12                                             ` Rafael J. Wysocki
2008-02-25 21:32         ` Jeff Garzik
2008-02-25 22:21           ` Pavel Machek
2008-02-26  8:54   ` new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Klaus S. Madsen
2008-02-26 21:32     ` Klaus S. Madsen
2008-02-26 21:44       ` Jiri Kosina
2008-02-27 22:13         ` Klaus S. Madsen
2008-02-27 23:20           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802252157.10412.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=astarikovskiy@suse.de \
    --cc=jeff@garzik.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.s.tsirkin@gmail.com \
    --cc=pavel@ucw.cz \
    --subject='broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).