LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors
@ 2008-02-25 20:57 Michael S. Tsirkin
  2008-02-25 21:00 ` Rafael J. Wysocki
  2008-02-25 21:04 ` Jeff Garzik
  0 siblings, 2 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2008-02-25 20:57 UTC (permalink / raw)
  To: Andrew Morton, LKML, Rafael J. Wysocki, Pavel Machek,
	Jeff Garzik, jgarzik, linux-ide

On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.

At one point I got lucky and got this on console (wrote down by hand,
there could be typos):
ata1: COMRESET failed (errno=-16)
ata1: COMRESET failed (errno=-16)
end_request: I/O error, dev sda sector 200554
Buffer I/O error on device dm-0, logical block 256
Buffer I/O error on device dm-0, logical block 15695875
Buffer I/O error on device dm-0, logical block 15695878
Buffer I/O error on device dm-0, logical block 15695887
Buffer I/O error on device dm-0, logical block 15695896
Buffer I/O error on device dm-0, logical block 15695914
Buffer I/O error on device dm-0, logical block 15958028
Buffer I/O error on device dm-0, logical block 22118530
Buffer I/O error on device dm-0, logical block 22315068
Buffer I/O error on device dm-0, logical block 22347824

git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA

After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
on top of 2.6.25-rc3 the kernel again resumes from suspend to ram.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors
  2008-02-25 20:57 new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors Michael S. Tsirkin
@ 2008-02-25 21:00 ` Rafael J. Wysocki
  2008-02-25 21:28   ` Bartlomiej Zolnierkiewicz
  2008-02-25 21:04 ` Jeff Garzik
  1 sibling, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2008-02-25 21:00 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: Andrew Morton, LKML, Pavel Machek, Jeff Garzik, jgarzik, linux-ide

On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
> On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
> Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.

Thanks for the report.

> At one point I got lucky and got this on console (wrote down by hand,
> there could be typos):
> ata1: COMRESET failed (errno=-16)
> ata1: COMRESET failed (errno=-16)
> end_request: I/O error, dev sda sector 200554
> Buffer I/O error on device dm-0, logical block 256
> Buffer I/O error on device dm-0, logical block 15695875
> Buffer I/O error on device dm-0, logical block 15695878
> Buffer I/O error on device dm-0, logical block 15695887
> Buffer I/O error on device dm-0, logical block 15695896
> Buffer I/O error on device dm-0, logical block 15695914
> Buffer I/O error on device dm-0, logical block 15958028
> Buffer I/O error on device dm-0, logical block 22118530
> Buffer I/O error on device dm-0, logical block 22315068
> Buffer I/O error on device dm-0, logical block 22347824
> 
> git bisect points at this commit:
> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
> power_state: get rid of write-only variable in SATA

Jeff, could you revert it, please?

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors
  2008-02-25 20:57 new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors Michael S. Tsirkin
  2008-02-25 21:00 ` Rafael J. Wysocki
@ 2008-02-25 21:04 ` Jeff Garzik
  2008-02-25 22:24   ` Pavel Machek
  1 sibling, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2008-02-25 21:04 UTC (permalink / raw)
  To: Michael S. Tsirkin, Pavel Machek
  Cc: Andrew Morton, LKML, Rafael J. Wysocki, linux-ide

Michael S. Tsirkin wrote:
> git bisect points at this commit:
> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
> power_state: get rid of write-only variable in SATA


Hello Pavel --

It looks like this not a write-only variable after all...

	Jeff



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors
  2008-02-25 21:00 ` Rafael J. Wysocki
@ 2008-02-25 21:28   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-25 21:28 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Michael S. Tsirkin, Andrew Morton, LKML, Pavel Machek,
	Jeff Garzik, jgarzik, linux-ide

On Monday 25 February 2008, Rafael J. Wysocki wrote:
> On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
> > On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
> > Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.
> 
> Thanks for the report.
> 
> > At one point I got lucky and got this on console (wrote down by hand,
> > there could be typos):
> > ata1: COMRESET failed (errno=-16)
> > ata1: COMRESET failed (errno=-16)
> > end_request: I/O error, dev sda sector 200554
> > Buffer I/O error on device dm-0, logical block 256
> > Buffer I/O error on device dm-0, logical block 15695875
> > Buffer I/O error on device dm-0, logical block 15695878
> > Buffer I/O error on device dm-0, logical block 15695887
> > Buffer I/O error on device dm-0, logical block 15695896
> > Buffer I/O error on device dm-0, logical block 15695914
> > Buffer I/O error on device dm-0, logical block 15958028
> > Buffer I/O error on device dm-0, logical block 22118530
> > Buffer I/O error on device dm-0, logical block 22315068
> > Buffer I/O error on device dm-0, logical block 22347824
> > 
> > git bisect points at this commit:
> > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
> > power_state: get rid of write-only variable in SATA
> 
> Jeff, could you revert it, please?

Jeff, this was applied between -rc2 and -rc3.

100% cleanup patches which change behavior are potentialy
risky and shouldn't be considered as a -rc material.

Thanks,
Bart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors
  2008-02-25 21:04 ` Jeff Garzik
@ 2008-02-25 22:24   ` Pavel Machek
  0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2008-02-25 22:24 UTC (permalink / raw)
  To: Jeff Garzik
  Cc: Michael S. Tsirkin, Andrew Morton, LKML, Rafael J. Wysocki, linux-ide

On Mon 2008-02-25 16:04:08, Jeff Garzik wrote:
> Michael S. Tsirkin wrote:
>> git bisect points at this commit:
>> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
>> power_state: get rid of write-only variable in SATA
>
>
> Hello Pavel --
>
> It looks like this not a write-only variable after all...

Yep, right and sorry.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-25 22:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-25 20:57 new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors Michael S. Tsirkin
2008-02-25 21:00 ` Rafael J. Wysocki
2008-02-25 21:28   ` Bartlomiej Zolnierkiewicz
2008-02-25 21:04 ` Jeff Garzik
2008-02-25 22:24   ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).