LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL
@ 2008-02-25 21:24 Anton Vorontsov
  2008-02-25 22:26 ` Evgeniy Polyakov
  0 siblings, 1 reply; 2+ messages in thread
From: Anton Vorontsov @ 2008-02-25 21:24 UTC (permalink / raw)
  To: Evgeniy Polyakov; +Cc: Matt Reimer, linux-kernel

On the error condition clk_get() returns ERR_PTR(..), so checking
for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm
clock isn't registered.

This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
for the return code.

Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
---
 drivers/w1/masters/ds1wm.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
index 688e435..78a14da 100644
--- a/drivers/w1/masters/ds1wm.c
+++ b/drivers/w1/masters/ds1wm.c
@@ -17,6 +17,7 @@
 #include <linux/pm.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
+#include <linux/err.h>
 #include <linux/delay.h>
 #include <linux/ds1wm.h>
 
@@ -374,8 +375,8 @@ static int ds1wm_probe(struct platform_device *pdev)
 		goto err1;
 
 	ds1wm_data->clk = clk_get(&pdev->dev, "ds1wm");
-	if (!ds1wm_data->clk) {
-		ret = -ENOENT;
+	if (IS_ERR(ds1wm_data->clk)) {
+		ret = PTR_ERR(ds1wm_data->clk);
 		goto err2;
 	}
 
-- 
1.5.4.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL
  2008-02-25 21:24 [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL Anton Vorontsov
@ 2008-02-25 22:26 ` Evgeniy Polyakov
  0 siblings, 0 replies; 2+ messages in thread
From: Evgeniy Polyakov @ 2008-02-25 22:26 UTC (permalink / raw)
  To: Anton Vorontsov; +Cc: Matt Reimer, linux-kernel, Andrew Morton

Hi Anton.

On Tue, Feb 26, 2008 at 12:24:26AM +0300, Anton Vorontsov (cbouatmailru@gmail.com) wrote:
> On the error condition clk_get() returns ERR_PTR(..), so checking
> for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm
> clock isn't registered.
> 
> This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
> for the return code.
> 
> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>

Both patches look good, thanks Anton.

Andrew, please merge them and add my ack if needed.
Thank you.

-- 
	Evgeniy Polyakov

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-25 22:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-25 21:24 [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL Anton Vorontsov
2008-02-25 22:26 ` Evgeniy Polyakov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).