LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: nicolas.ferre@rfo.atmel.com, linux@maxim.org.za,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [patch 2.6.25-rc2-git 2/2] atmel_tc clocksource/clockevent code
Date: Tue, 26 Feb 2008 01:25:33 -0800	[thread overview]
Message-ID: <200802260125.33713.david-b@pacbell.net> (raw)
In-Reply-To: <20080226101625.31f6954d@hskinnemoen.norway.atmel.com>

On Tuesday 26 February 2008, Haavard Skinnemoen wrote:
> > Another way to address that rm9200 issue would be to just rate
> > the TC clockevent source lower than the one based on the system
> > timer, so it's set up but never enabled ... and remember "t2_clk",
> > calling clk_enable() only when that clockevent device is active.
> > 
> > That would address one half of the suspend/resume equation too,
> > ensuring that clock is disabled during suspend...
> 
> Yes, we could probably do that. Which means we can just remove all the
> ifdeffery?

There'd still be the #ifdef for CONFIG_GENERIC_CLOCKEVENTS,
unless all the platforms get updated to support that.  Right
now it's a "patches available but not merged" situation.


> > The other half being:  how to clk_disable(t0_clk) during system
> > suspend?  (And t1_clk on some systems.)  There's currently no
> > clocksource.set_mode() call; evidently there's an assumption that
> > such counters cost no power, so they can always be left running.
> 
> Yes...that would be a clocksource core issue I guess. Better leave that
> for later...

My thoughts exactly.  ;)

Plus a bit of puzzlement why that didn't trigger at least a
warning during AT91 suspend testing.  There used to be warnings
there about clocks which were wrongly left enabled...

- Dave

      reply	other threads:[~2008-02-26  9:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23  1:28 David Brownell
2008-02-24 18:21 ` Haavard Skinnemoen
2008-02-24 23:42   ` David Brownell
2008-02-25 11:31     ` Haavard Skinnemoen
2008-02-25 17:51       ` David Brownell
2008-02-26  9:16         ` Haavard Skinnemoen
2008-02-26  9:25           ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802260125.33713.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@linux-foundation.org \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@rfo.atmel.com \
    --subject='Re: [patch 2.6.25-rc2-git 2/2] atmel_tc clocksource/clockevent code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).