LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nix <nix@esperi.org.uk>, Peter Osterlund <petero2@telia.com>,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	Jan Kara <jack@ucw.cz>
Subject: Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?
Date: Tue, 26 Feb 2008 17:41:23 +0100	[thread overview]
Message-ID: <20080226164123.GB28101@duck.suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0802261230510.30955@jikos.suse.cz>

On Tue 26-02-08 12:37:17, Jiri Kosina wrote:
> On Tue, 26 Feb 2008, Ingo Molnar wrote:
> 
> > > +	name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > > +	fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > > +
> > > +	if (!name || !fname) {
> > > +		*err = -ENOMEM;
> > > +		return NULL;
> > > +	}
> > > +
> > >  	if (dentry) {
> > >  		if (!dentry->d_name.len) {
> > >  			*err = -EINVAL;
> > this bit is missing i think:
> > 	if (name)
> > 		kfree(name);
> > 	if (fname)
> > 		kfree(fname);
> 
> Ergh, of course, stupid me, sorry, it should be freed on all exit paths. I 
> am not sending updated patch, as Jan is probably working on complete 
> removal of one of those fields ... ?
  Yes, I'll convert one variable to kmalloc and the other one remove
completely. Stay tuned ;).

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2008-02-26 16:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24  1:56 2.6.24.2: 4KSTACKS + PCA403CD IDE CD + pcdrw + mount + PREEMPT -> stack overflow Nix
2008-02-24 15:59 ` 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related? Nix
2008-02-24 16:56   ` Peter Osterlund
2008-02-24 17:02     ` Nix
2008-02-25 20:30       ` Andrew Morton
2008-02-25 22:48         ` Jan Kara
2008-02-25 22:51           ` Andrew Morton
2008-02-26 11:10           ` Jiri Kosina
2008-02-26 11:29             ` Ingo Molnar
2008-02-26 11:37               ` Jiri Kosina
2008-02-26 16:41                 ` Jan Kara [this message]
2008-02-26 17:25             ` Daniel Hazelton
2008-03-06 16:14       ` Jan Kara
2008-03-10 20:09         ` Nix
2008-02-25 20:25     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080226164123.GB28101@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=jack@ucw.cz \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nix@esperi.org.uk \
    --cc=petero2@telia.com \
    --subject='Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).