LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Dave Jones <davej@codemonkey.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Date: Tue, 26 Feb 2008 22:56:41 +0100	[thread overview]
Message-ID: <20080226215641.GE10280@elf.ucw.cz> (raw)
In-Reply-To: <20080226182241.GB7714@codemonkey.org.uk>

On Tue 2008-02-26 13:22:41, Dave Jones wrote:
> On Tue, Feb 26, 2008 at 07:16:11PM +0100, Pavel Machek wrote:
>  > On Tue 2008-02-26 13:10:01, Dave Jones wrote:
>  > > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote:
>  > >  
>  > >  > > if by 'custom' you mean the solution everyone agreed to work
>  > >  > > toward at the power management summit several years ago
>  > >  > > (hal/pm-utils) then, yes.
>  > >  > 
>  > >  > I must have been on different summit... I believe it is bad to tie
>  > >  > s2ram to hal, because it makes testing on minimal system hard.
>  > >  > 
>  > >  > Anyway, what is the "default" way to trigger s2ram for Andrew? Perhaps
>  > >  > Fedora already has his machine whitelisted...
>  > > 
>  > > There is no s2ram. pm-suspend uses the white/black-lists in pm-utils.
>  > > Remember that? The cross-distro package everyone agreed was a good idea
>  > > so that every distro didn't have their own magic utility ?
>  > 
>  > Well, we have cross-distro package, it is at suspend.sf.net , and it
>  > can bring up video - which is kind of important. (It is single binary,
>  > so it can be pagelocked -- which is important for s2disk).
>  > 
>  > Plus it does not depend on HAL.
> 
> Neither does pm-utils.  Once again for the hard of thinking..
> 
> The mechanism belongs in pm-utils.  HAL is just a fancy wrapper around that.
> Don't want/like hal? fine, a smaller wrapper around pm-suspend and friends
> is trivial (or even unnecessary if you're happy with running pm-suspend by hand)

Seems like pm-utils is just a thin wrapper around s2ram, at least in
version debian ships. It does not seem to have its own whitelist.

Now, take a look at 

/usr/lib/pm-utils/functions

... 

        if [ -x /usr/sbin/s2ram ]; then
                if [ -n "$S2RAM_OPTS" ]; then
                        # Trust HAL or the user to pass the correct
options
                        /usr/sbin/s2ram $S2RAM_OPTS
                elif /usr/sbin/s2ram --test > /dev/null ; then
                        # Trust s2ram's internal whitelist
                        /usr/sbin/s2ram
                else
                        # Unknown machine
                        echo "This machine is unkown, please try to
find out how to suspend this machine. See s2ram(8)."
                fi
        else
                echo -n "mem" > /sys/power/state
        fi

...so it is ready to use s2ram, but will fall back to
echo. Unfortunately, that will mean no video resume on _many_
machines.

To give some numbers: according to s2ram whitelist, we can restore
video on 410 machines. On 74 of them, s2ram is not needed. So
approximately 80% of machines need s2ram (at least in configuration
without X running)....

Pretty please, can we get s2ram for Fedora, so that video is restored
there?

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-02-26 21:56 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 19:19 new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Michael S. Tsirkin
2008-02-25 19:42 ` Alexey Starikovskiy
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:50     ` Alexey Starikovskiy
2008-02-25 21:01       ` Michael S. Tsirkin
2008-02-25 22:33         ` Alexey Starikovskiy
2008-02-25 23:18           ` Michael S. Tsirkin
2008-02-25 19:46 ` Andrew Morton
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:45   ` Michael S. Tsirkin
2008-02-25 20:57     ` broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) Rafael J. Wysocki
2008-02-25 21:26       ` Pavel Machek
2008-02-25 21:31         ` Michael S. Tsirkin
2008-02-25 21:50           ` Pavel Machek
2008-02-25 22:15             ` Michael S. Tsirkin
2008-02-25 22:20               ` Pavel Machek
2008-02-25 22:36                 ` Michael S. Tsirkin
2008-02-25 22:39                   ` Andrew Morton
2008-02-25 22:48                     ` Michael S. Tsirkin
2008-02-25 22:53                       ` Andrew Morton
2008-02-25 22:58                         ` Michael S. Tsirkin
2008-02-25 22:58                         ` Pavel Machek
     [not found]                           ` <20080225155550.4a020dfb.akpm@linux-foundation.org>
     [not found]                             ` <20080226000007.GB22102@atrey.karlin.mff.cuni.cz>
2008-02-26 10:11                               ` Pavel Machek
2008-02-26 17:46                                 ` Dave Jones
2008-02-26 17:59                                   ` Pavel Machek
2008-02-26 18:10                                     ` Dave Jones
2008-02-26 18:16                                       ` Pavel Machek
2008-02-26 18:22                                         ` Dave Jones
2008-02-26 21:56                                           ` Pavel Machek [this message]
2008-02-26 22:23                                             ` Dave Jones
2008-02-26 22:31                                               ` Rafael J. Wysocki
2008-02-26 22:51                                               ` Pavel Machek
2008-02-27 13:12                                             ` Matthew Garrett
2008-02-27 13:23                                               ` Rafael J. Wysocki
2008-02-27 15:51                                                 ` Stefan Seyfried
2008-02-27 15:55                                                   ` Matthew Garrett
2008-02-26 18:56                                         ` Andrew Morton
2008-02-26 20:09                                           ` Len Brown
2008-02-26 23:31                                           ` Ray Lee
2008-02-27  0:12                                             ` Rafael J. Wysocki
2008-02-25 21:32         ` Jeff Garzik
2008-02-25 22:21           ` Pavel Machek
2008-02-26  8:54   ` new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Klaus S. Madsen
2008-02-26 21:32     ` Klaus S. Madsen
2008-02-26 21:44       ` Jiri Kosina
2008-02-27 22:13         ` Klaus S. Madsen
2008-02-27 23:20           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080226215641.GE10280@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --subject='Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).