LKML Archive on
help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <>
To: Borislav Petkov <>
	Borislav Petkov <>,
	Paolo Ciarrocchi <>
Subject: Re: [PATCH] ide-cd: fix some codestyle and most of the issues
Date: Tue, 26 Feb 2008 23:37:29 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tuesday 26 February 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <>
> ---
>  drivers/ide/ide-cd.c |  634 +++++++++++++++++++++++++------------------------
>  1 files changed, 323 insertions(+), 311 deletions(-)

With 300 lines changed this is not trivial to review/apply anymore
(yeah, I sound like a broken record ;-) and since I've already applied
Paolo's patch from two days ago this one heavily rejects...

Moreover md5sum is different before/after the patch - I tried really hard
to figure out why (by reverting some changes) but finally I gave up.

- resync
- factor out changes which affect resulting binary
- resubmit


  reply	other threads:[~2008-02-26 22:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26  7:49 ide-cd: trivial fixes Borislav Petkov
2008-02-26  7:49 ` [PATCH] ide-cd: put proc-related functions together under single ifdef Borislav Petkov
2008-02-26 22:25   ` Bartlomiej Zolnierkiewicz
2008-02-26  7:49 ` [PATCH] ide-cd: fix some codestyle and most of the issues Borislav Petkov
2008-02-26 22:37   ` Bartlomiej Zolnierkiewicz [this message]
2008-02-26 23:16     ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] ide-cd: fix some codestyle and most of the issues' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).