LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Martin Michlmayr <tbm@cyrius.com>,
linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Ralf Baechle <ralf@linux-mips.org>,
linux-crypto@vger.kernel.org
Subject: Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit division
Date: Wed, 27 Feb 2008 08:22:07 +0200 [thread overview]
Message-ID: <20080227062207.GB10603@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080226160439.5941cc31.akpm@linux-foundation.org>
On Tue, Feb 26, 2008 at 04:04:39PM -0800, Andrew Morton wrote:
> On Tue, 26 Feb 2008 21:52:40 +0300 Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
>
> > Hi Adrian.
> >
> > On Tue, Feb 26, 2008 at 05:34:21PM +0200, Adrian Bunk (bunk@kernel.org) wrote:
> > > Using ndelay() with a 64bit variable as parameter can result in build
> > > errors like the following on some 32bit systems when it results in a
> > > 64bit division:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > MODPOST 759 modules
> > > ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
> > >
> > > <-- snip -->
> > >
> > > Reported by Martin Michlmayr.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > Yep, ndelay() uses division, thanks a lot Adrian for spotting this.
>
> hm. Where?
>...
include/linux/delay.h:35
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-02-27 6:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 12:21 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined! Martin Michlmayr
2008-02-26 12:28 ` Patrick McHardy
2008-02-26 13:39 ` Martin Michlmayr
2008-02-26 15:34 ` [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit division Adrian Bunk
2008-02-26 17:20 ` Martin Michlmayr
2008-02-26 18:52 ` Evgeniy Polyakov
2008-02-27 0:04 ` Andrew Morton
2008-02-27 6:22 ` Adrian Bunk [this message]
2008-02-27 6:47 ` Andrew Morton
2008-02-28 8:02 ` Adrian Bunk
2008-02-27 15:59 ` Evgeniy Polyakov
2008-02-27 3:46 ` 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined! David Rientjes
2008-02-27 11:29 ` Patrick McHardy
2008-02-28 19:40 ` Andrew Morton
2008-02-27 14:53 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227062207.GB10603@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tbm@cyrius.com \
--subject='Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit division' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).