LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] CONNECTOR: make cn_already_initialized static
@ 2008-02-27  2:22 Li Zefan
  2008-02-27  2:25 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2008-02-27  2:22 UTC (permalink / raw)
  To: David Miller; +Cc: Evgeniy Polyakov, LKML

It is used in connector.c only, so make it static.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 drivers/connector/connector.c |    2 +-
 include/linux/connector.h     |    2 --
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index fea2d3e..85e2ba7 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -47,7 +47,7 @@ static LIST_HEAD(notify_list);
 
 static struct cn_dev cdev;
 
-int cn_already_initialized = 0;
+static int cn_already_initialized;
 
 /*
  * msg->seq and msg->ack are used to determine message genealogy.
diff --git a/include/linux/connector.h b/include/linux/connector.h
index da6dd95..96a89d3 100644
--- a/include/linux/connector.h
+++ b/include/linux/connector.h
@@ -170,7 +170,5 @@ int cn_cb_equal(struct cb_id *, struct cb_id *);
 
 void cn_queue_wrapper(struct work_struct *work);
 
-extern int cn_already_initialized;
-
 #endif				/* __KERNEL__ */
 #endif				/* __CONNECTOR_H */
-- 
1.5.4.rc3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] CONNECTOR: make cn_already_initialized static
  2008-02-27  2:22 [PATCH] CONNECTOR: make cn_already_initialized static Li Zefan
@ 2008-02-27  2:25 ` David Miller
  2008-02-27 10:38   ` Evgeniy Polyakov
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-02-27  2:25 UTC (permalink / raw)
  To: lizf; +Cc: johnpol, linux-kernel

From: Li Zefan <lizf@cn.fujitsu.com>
Date: Wed, 27 Feb 2008 10:22:12 +0800

> It is used in connector.c only, so make it static.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] CONNECTOR: make cn_already_initialized static
  2008-02-27  2:25 ` David Miller
@ 2008-02-27 10:38   ` Evgeniy Polyakov
  0 siblings, 0 replies; 3+ messages in thread
From: Evgeniy Polyakov @ 2008-02-27 10:38 UTC (permalink / raw)
  To: David Miller; +Cc: lizf, linux-kernel

Hi.

On Tue, Feb 26, 2008 at 06:25:45PM -0800, David Miller (davem@davemloft.net) wrote:
> > It is used in connector.c only, so make it static.
> > 
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> Applied, thanks.

Thanks for resolving this guys.

-- 
	Evgeniy Polyakov

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-27 10:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-27  2:22 [PATCH] CONNECTOR: make cn_already_initialized static Li Zefan
2008-02-27  2:25 ` David Miller
2008-02-27 10:38   ` Evgeniy Polyakov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).