LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PCI] duplicate sysfs symbols getting registered in current git
Date: Wed, 27 Feb 2008 12:47:48 +0100	[thread overview]
Message-ID: <20080227124748.2e89e628@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0802271222530.5059@axis700.grange>

On Wed, 27 Feb 2008 12:24:54 +0100 (CET),
Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:

> Ok, result #1: kernel panic 
> http://home.arcor.de/g.liakhovetski/ap400/imga0045.jpg. If necessary, can 
> try a serial console, but that would be more difficult.

Looking at device_add(): Does the following patch make the oops go away?

---
 drivers/base/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/drivers/base/core.c
+++ linux-2.6/drivers/base/core.c
@@ -780,7 +780,7 @@ int device_add(struct device *dev)
 	dev = get_device(dev);
 	if (!dev || !strlen(dev->bus_id)) {
 		error = -EINVAL;
-		goto Error;
+		goto Done;
 	}
 
 	pr_debug("device: '%s': %s\n", dev->bus_id, __FUNCTION__);

  parent reply	other threads:[~2008-02-27 11:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 20:52 Guennadi Liakhovetski
2008-02-20  6:38 ` Greg KH
2008-02-25 12:43   ` Guennadi Liakhovetski
2008-02-25 18:15     ` Guennadi Liakhovetski
2008-02-25 20:25       ` Greg KH
2008-02-25 20:31         ` Guennadi Liakhovetski
2008-02-25 21:14           ` Greg KH
2008-02-25 22:03             ` Guennadi Liakhovetski
2008-02-25 22:21               ` Greg KH
2008-02-26 20:16     ` Greg KH
2008-02-27 11:24       ` Guennadi Liakhovetski
2008-02-27 11:27         ` Guennadi Liakhovetski
2008-02-27 11:47         ` Cornelia Huck [this message]
2008-02-27 12:33           ` Guennadi Liakhovetski
2008-02-27 13:21             ` Cornelia Huck
2008-02-27 13:46               ` Guennadi Liakhovetski
2008-02-27 14:38                 ` Cornelia Huck
2008-02-27 11:39       ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080227124748.2e89e628@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PCI] duplicate sysfs symbols getting registered in current git' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).