LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarod Wilson <jwilson@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
	Harvey Harrison <harvey.harrison@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	linuxppc-dev@ozlabs.org, Kristian Hoegsberg <krh@bitplanet.net>
Subject: Re: [PATCH 1/2] firewire: endianess fix
Date: Wed, 27 Feb 2008 14:58:28 -0500	[thread overview]
Message-ID: <200802271458.28401.jwilson@redhat.com> (raw)
In-Reply-To: <tkrat.9e19fa31951506af@s5r6.in-berlin.de>

On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote:
> The generation of incoming requests was filled in in wrong byte order on
> machines with big endian CPU.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Cc: sparclinux@vger.kernel.org
> Cc: linuxppc-dev@ozlabs.org
> ---
>
> This patch is a shot in the dark, based on a warning when building with
> C=1 CHECKFLAGS="-D__CHECK_ENDIAN__".  Is it really a fix, or was the
> previous code accidentally correct?
>
> This needs to be tested on different big endian PCs, if possible with
> the Apple Uninorth FireWire controller and other types of controllers.
> One test which involves ohci->request_generation is simply with an SBP-2
> device (harddisk, CD-ROM...).  Does SBP-2 login etc. work?

Works just fine with the Apple UniNorth controller in my powerbook in cursory 
testing. Tested with multiple sbp2 hard disks, plugging and unplugging, 
mounting and unmounting, etc.

> If possible, also test whether the device remains accessible after
> forcing a bus reset, e.g. by "echo br short > firecontrol".  You need
> the easy to build utility firecontrol and a libraw1394 with "juju"
> backend.  See wiki.linux1394.org for directions.

Forgot to check that it survived bus resets. Will try to double-check that 
tonight. I don't have any other ppc systems w/firewire controllers handy at 
the moment to try other controllers, but can probably manage to get one set 
up soon...

-- 
Jarod Wilson
jwilson@redhat.com

  parent reply	other threads:[~2008-02-27 19:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 22:03 sparse - make __CHECK_ENDIAN__ default enabled? Sam Ravnborg
2008-02-20 22:18 ` Harvey Harrison
2008-02-23 11:23   ` [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?) Stefan Richter
2008-02-23 11:24     ` [PATCH 1/2] firewire: endianess fix Stefan Richter
2008-02-23 11:36       ` Stefan Richter
2008-02-23 12:12       ` Stefan Richter
2008-03-01 12:36         ` Stefan Richter
2008-02-27 19:58       ` Jarod Wilson [this message]
2008-02-27 20:08         ` Stefan Richter
2008-02-27 20:21           ` Jarod Wilson
2008-02-28  2:40         ` Benjamin Herrenschmidt
2008-02-28  3:21           ` Jarod Wilson
2008-02-28  6:25             ` Benjamin Herrenschmidt
2008-02-28 18:42               ` Jarod Wilson
2008-02-28 23:26                 ` Benjamin Herrenschmidt
2008-02-29  5:48                   ` Jarod Wilson
2008-02-29  6:00                     ` Benjamin Herrenschmidt
2008-02-29 11:26                     ` Paul Mackerras
2008-02-29 11:52                       ` Stefan Richter
2008-02-29 21:49                         ` Benjamin Herrenschmidt
2008-02-29 15:34                       ` Jarod Wilson
2008-03-03  9:19                     ` Gabriel Paubert
2008-03-03 14:35                       ` Stefan Richter
2008-03-05 22:59                         ` Gabriel Paubert
2008-03-05 23:26                           ` Stefan Richter
2008-03-06 20:23                             ` Gabriel Paubert
2008-02-28  3:33         ` Jarod Wilson
2008-02-28  2:41       ` Benjamin Herrenschmidt
2008-02-28  8:41         ` Stefan Richter
2008-02-23 11:24     ` [PATCH 2/2] firewire: endianess annotations Stefan Richter
2008-03-01  5:23     ` [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?) Jarod Wilson
2008-02-20 22:39 ` sparse - make __CHECK_ENDIAN__ default enabled? Harvey Harrison
2008-02-20 22:51   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802271458.28401.jwilson@redhat.com \
    --to=jwilson@redhat.com \
    --cc=harvey.harrison@gmail.com \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    --subject='Re: [PATCH 1/2] firewire: endianess fix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).