LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <adrian.bunk@movial.fi>
To: Olaf Hering <olaf@aepfle.de>,
	Anton Vorontsov <avorontsov@ru.mvista.com>,
	Vitaly Bordug <vitb@kernel.crashing.org>,
	Jeff Garzik <jeff@garzik.org>,
	Kumar Gala <galak@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [2.6.25 patch] FIXED_PHY must depend on PHYLIB=y
Date: Wed, 27 Feb 2008 17:07:54 +0200	[thread overview]
Message-ID: <20080227150754.GA29269@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <200802271158.00453.olaf@aepfle.de>

This patch fixes the following build error introduced by commit 
a79d8e93d300adb84cccc38ac396cfb118c238ad and reported by Olaf Hering:

<--  snip  -->

...
  LD      .tmp_vmlinux1
arch/powerpc/sysdev/built-in.o: In function `of_add_fixed_phys':
fsl_soc.c:(.init.text+0xd34): undefined reference to `fixed_phy_add'
make: *** [.tmp_vmlinux1] Error 1

<--   snip  -->

Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>

---
47a94f1d74e448d39f34f0ad37f8b4f69412ee13 diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index f4ca059..3ac8529 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -67,6 +67,7 @@ config REALTEK_PHY
 
 config FIXED_PHY
 	bool "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs"
+	depends on PHYLIB=y
 	---help---
 	  Adds the platform "fixed" MDIO Bus to cover the boards that use
 	  PHYs that are not connected to the real MDIO bus.


  parent reply	other threads:[~2008-02-27 15:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 10:58 undefined reference to fixed_phy_add, from of_add_fixed_phys Olaf Hering
2008-02-27 11:07 ` Adrian Bunk
2008-02-27 15:07 ` Adrian Bunk [this message]
2008-02-28 10:30   ` [2.6.25 patch] FIXED_PHY must depend on PHYLIB=y Olaf Hering
2008-03-05 12:18   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080227150754.GA29269@cs181133002.pp.htv.fi \
    --to=adrian.bunk@movial.fi \
    --cc=avorontsov@ru.mvista.com \
    --cc=galak@kernel.crashing.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=vitb@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).