LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] elfcore-compat fix uid/gid types
@ 2008-02-26 21:20 Roland McGrath
  2008-02-27 15:16 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Roland McGrath @ 2008-02-26 21:20 UTC (permalink / raw)
  To: Andrew Morton, Linus Torvalds; +Cc: Ingo Molnar, linux-kernel


I overlooked the difference between __kernel_uid_t and uid_t when defining
struct compat_elf_prpsinfo.  The result is a regression in 32-bit core
dumps on x86_64, where the NT_PRPSINFO note has the wrong size and layout.
This patch fixes it.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 include/linux/elfcore-compat.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/elfcore-compat.h b/include/linux/elfcore-compat.h
index 532d13a..0a90e1c 100644
--- a/include/linux/elfcore-compat.h
+++ b/include/linux/elfcore-compat.h
@@ -45,8 +45,8 @@ struct compat_elf_prpsinfo
 	char				pr_zomb;
 	char				pr_nice;
 	compat_ulong_t			pr_flag;
-	compat_uid_t			pr_uid;
-	compat_gid_t			pr_gid;
+	__compat_uid_t			pr_uid;
+	__compat_gid_t			pr_gid;
 	compat_pid_t			pr_pid, pr_ppid, pr_pgrp, pr_sid;
 	char				pr_fname[16];
 	char				pr_psargs[ELF_PRARGSZ];

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] elfcore-compat fix uid/gid types
  2008-02-26 21:20 [PATCH] elfcore-compat fix uid/gid types Roland McGrath
@ 2008-02-27 15:16 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-27 15:16 UTC (permalink / raw)
  To: Roland McGrath; +Cc: Andrew Morton, Linus Torvalds, linux-kernel


* Roland McGrath <roland@redhat.com> wrote:

> I overlooked the difference between __kernel_uid_t and uid_t when 
> defining struct compat_elf_prpsinfo.  The result is a regression in 
> 32-bit core dumps on x86_64, where the NT_PRPSINFO note has the wrong 
> size and layout. This patch fixes it.
> 
> Signed-off-by: Roland McGrath <roland@redhat.com>

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-27 15:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-26 21:20 [PATCH] elfcore-compat fix uid/gid types Roland McGrath
2008-02-27 15:16 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).