LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andres Salomon <dilinger@queued.net>
Cc: adaplas@gmail.com, linux-kernel@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net,
	info-linux@geode.amd.com, jordan.crouse@amd.com,
	dwmw2@infradead.org
Subject: Re: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument
Date: Wed, 27 Feb 2008 16:31:05 -0800	[thread overview]
Message-ID: <20080227163105.e1b96023.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080223011045.48e6cb8e@ephemeral>

On Sat, 23 Feb 2008 01:10:45 -0500
Andres Salomon <dilinger@queued.net> wrote:

> @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options)
>  		if (!*opt)
>  			continue;
>  
> -		mode_option = opt;
> +		if (!strncmp(opt, "fbsize:", 7))
> +			fbsize = simple_strtoul(opt+7, NULL, 0);
> +		else
> +			mode_option = opt;
>  	}

The above shouldn't be necessary.

And it should have been documented in Documentation/kernel-parameters.txt.

And "fbsize=N" would be a lot more conventional than "fbsize:N"

I suspect that the formulation you have here will not permit "fbsize:128k",
whereas "fbsize=128k" or "gxfb.fbsize=128k" should work.  Needs checking.

>  	return 0;
> @@ -456,5 +458,8 @@ module_exit(gxfb_cleanup);
>  module_param(mode_option, charp, 0);
>  MODULE_PARM_DESC(mode_option, "video mode (<x>x<y>[-<bpp>][@<refr>])");
>  
> +module_param(fbsize, int, 0);
> +MODULE_PARM_DESC(fbsize, "video memory size");
> +

Because the module_param() already makes fbsize available on the kernel
boot command line via gxfb.fbsize=42 (or something similar).



  reply	other threads:[~2008-02-28  0:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23  6:10 Andres Salomon
2008-02-28  0:31 ` Andrew Morton [this message]
2008-02-28  0:58   ` Andres Salomon
2008-02-28  1:12     ` Jordan Crouse
2008-03-09  1:19     ` [PATCH 1/4] " Andres Salomon
2008-03-09  1:19     ` Andres Salomon
2008-03-09 18:12       ` Randy Dunlap
2008-03-09 22:00       ` [Linux-fbdev-devel] " Ondrej Zajicek
2008-03-09 23:57         ` Andres Salomon
2008-03-10  8:16           ` Geert Uytterhoeven
2008-03-11 20:25   ` Andres Salomon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080227163105.e1b96023.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adaplas@gmail.com \
    --cc=dilinger@queued.net \
    --cc=dwmw2@infradead.org \
    --cc=info-linux@geode.amd.com \
    --cc=jordan.crouse@amd.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).