LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Priit Laes <plaes@plaes.org>
Subject: Re: [PATCH] x86 vdso: fix build locale dependency
Date: Wed, 27 Feb 2008 21:43:21 +0100	[thread overview]
Message-ID: <20080227204321.GA13309@uranus.ravnborg.org> (raw)
In-Reply-To: <20080227194215.0B5A32700FD@magilla.localdomain>

On Wed, Feb 27, 2008 at 11:42:15AM -0800, Roland McGrath wrote:
> 
> Priit Laes discovered that the sed command processing nm output was
> sensitive to locale settings.  This was addressed in commit
> 03994f01e8b72b3d01fd3d09d1cc7c9f421a727c by using [:alnum:] in place of
> [a-zA-Z0-9].  But that too is locale-dependent and may not always match
> the identifiers it needs to.  The better fix is just to run sed et al
> with a fixed locale setting in all builds.

Priit's original patch used the LC_ALL trick. It is
me to blame that it was replaced with [:alnum:] :-(

	Sam

  reply	other threads:[~2008-02-27 20:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 19:42 Roland McGrath
2008-02-27 20:43 ` Sam Ravnborg [this message]
2008-02-27 20:45   ` Ingo Molnar
2008-02-27 20:52     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080227204321.GA13309@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=plaes@plaes.org \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] x86 vdso: fix build locale dependency' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).