LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: joel.becker@oracle.com
Cc: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] fs/configfs/ cleanups
Date: Wed, 27 Feb 2008 23:20:48 +0200 [thread overview]
Message-ID: <20080227212048.GM29269@cs181133002.pp.htv.fi> (raw)
This patch contains the following cleanups:
- make the needlessly global file.c:configfs_add_file() static
- #if 0 the unused inode.c:configfs_hash_and_remove()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 17 Feb 2008
fs/configfs/configfs_internal.h | 3 ---
fs/configfs/file.c | 3 ++-
fs/configfs/inode.c | 2 ++
3 files changed, 4 insertions(+), 4 deletions(-)
651b7a33c0dce1790230fe8ba9b7445cd69c8bde diff --git a/fs/configfs/configfs_internal.h b/fs/configfs/configfs_internal.h
index cca9860..378fa36 100644
--- a/fs/configfs/configfs_internal.h
+++ b/fs/configfs/configfs_internal.h
@@ -63,9 +63,6 @@ extern int configfs_create_file(struct config_item *, const struct configfs_attr
extern int configfs_make_dirent(struct configfs_dirent *,
struct dentry *, void *, umode_t, int);
-extern int configfs_add_file(struct dentry *, const struct configfs_attribute *, int);
-extern void configfs_hash_and_remove(struct dentry * dir, const char * name);
-
extern const unsigned char * configfs_get_name(struct configfs_dirent *sd);
extern void configfs_drop_dentry(struct configfs_dirent *sd, struct dentry *parent);
extern int configfs_setattr(struct dentry *dentry, struct iattr *iattr);
diff --git a/fs/configfs/file.c b/fs/configfs/file.c
index 397cb50..f331a40 100644
--- a/fs/configfs/file.c
+++ b/fs/configfs/file.c
@@ -314,7 +314,8 @@ const struct file_operations configfs_file_operations = {
};
-int configfs_add_file(struct dentry * dir, const struct configfs_attribute * attr, int type)
+static int configfs_add_file(struct dentry * dir,
+ const struct configfs_attribute * attr, int type)
{
struct configfs_dirent * parent_sd = dir->d_fsdata;
umode_t mode = (attr->ca_mode & S_IALLUGO) | S_IFREG;
diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c
index 4c1ebff..dccff59 100644
--- a/fs/configfs/inode.c
+++ b/fs/configfs/inode.c
@@ -233,6 +233,7 @@ void configfs_drop_dentry(struct configfs_dirent * sd, struct dentry * parent)
}
}
+#if 0
void configfs_hash_and_remove(struct dentry * dir, const char * name)
{
struct configfs_dirent * sd;
@@ -255,6 +256,7 @@ void configfs_hash_and_remove(struct dentry * dir, const char * name)
}
mutex_unlock(&dir->d_inode->i_mutex);
}
+#endif /* 0 */
int __init configfs_inode_init(void)
{
next reply other threads:[~2008-02-27 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 21:20 Adrian Bunk [this message]
2008-02-27 22:36 ` Joel Becker
2008-03-03 18:07 ` [2.6 " Adrian Bunk
2008-03-03 20:17 ` Joel Becker
-- strict thread matches above, loose matches on Subject: below --
2008-02-17 8:18 [RFC: 2.6 " Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227212048.GM29269@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [RFC: 2.6 patch] fs/configfs/ cleanups' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).