LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bongani Hlope <bonganilinux@mweb.co.za>
To: Robert Fitzsimons <robfitz@273k.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bttv: Re-enabling radio support requires the use of struct bttv_fh.
Date: Wed, 27 Feb 2008 23:45:43 +0200	[thread overview]
Message-ID: <200802272345.43209.bonganilinux@mweb.co.za> (raw)
In-Reply-To: <20080227014729.GC2685@localhost>

On Wednesday 27 February 2008 03:47:29 Robert Fitzsimons wrote:
> A number of the radio tuner ioctl functions are shared with the TV
> tuner, these functions require a struct bttv_fh data structure to be
> allocated and initialized.
>
> Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
> ---
>  drivers/media/video/bt8xx/bttv-driver.c |   21 ++++++++++++++++-----
>  1 files changed, 16 insertions(+), 5 deletions(-)
> 
> 
> Mauro, the radio_open function may want to do more initialisation then
> the amount I copied from bttv_open.

Thanx Robert

I have applied both your patches and my radio works, but my TV doesn't work 
anymore (no picture or sound). But when I exit the radio program I get this 
oops:


BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
IP: [<ffffffff8030cd72>] kref_get+0xc/0x29
PGD 72230067 PUD 6dbd1067 PMD 0
Oops: 0000 [1] PREEMPT SMP
CPU 1
Modules linked in: snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq 
binfmt_misc loop nls_cp437 vfat fat nls_iso8859_1 ntfs thermal processor fan 
container button pcspkr snd_pcm_oss snd_mixer_oss snd_emu10k1 tuner tea5767 
tda8290 tuner_xc2028 tda9887 tuner_simple snd_rawmidi mt20xx snd_ac97_codec 
tea5761 bttv ac97_bus snd_pcm ir_common snd_seq_device firewire_ohci 
compat_ioctl32 snd_timer firewire_core videodev snd_page_alloc v4l1_compat 
uhci_hcd snd_util_mem ehci_hcd crc_itu_t v4l2_common snd_hwdep 
videobuf_dma_sg ohci1394 usbcore sr_mod ide_cd_mod snd videobuf_core ieee1394 
emu10k1_gp tg3 cdrom btcx_risc sg i2c_viapro gameport tveeprom evdev 
soundcore
Pid: 4319, comm: radio Not tainted 2.6.25-rc3-dirty #42
RIP: 0010:[<ffffffff8030cd72>]  [<ffffffff8030cd72>] kref_get+0xc/0x29
RSP: 0018:ffff810065211db8  EFLAGS: 00010296
RAX: ffff81006d815880 RBX: 0000000000000010 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff810065211e28 RDI: 0000000000000010
RBP: ffff810065211dc8 R08: 0000000000000000 R09: 0000001000000000
R10: 0000000000000000 R11: 0000000000000246 R12: ffff810065211e28
R13: 0000000000000000 R14: 0000000000000000 R15: fffffffffffffff8
FS:  00007fe0f915f6f0(0000) GS:ffff81007fb89dc0(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000000000000010 CR3: 0000000063e8f000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process radio (pid: 4319, threadinfo ffff810065210000, task ffff810068e534e0)
Stack:  ffff810065211ea8 0000000000000000 ffff810065211e08 ffffffff8044b362
 ffff810063dc0440 ffff810065211e28 0000000000000000 ffffffff803c0b75
 ffff810065211e78 ffff81007fb55580 ffff810065211e18 ffffffff8037be03
Call Trace:
 [<ffffffff8044b362>] klist_next+0x5d/0x8a
 [<ffffffff803c0b75>] ? i2c_cmd+0x0/0x3b
 [<ffffffff8037be03>] next_device+0x9/0x19
 [<ffffffff8037be4a>] device_for_each_child+0x37/0x5c
 [<ffffffff803bf371>] i2c_clients_command+0x23/0x25
 [<ffffffff88149b2a>] :bttv:bttv_call_i2c_clients+0x16/0x18
 [<ffffffff88142bf3>] :bttv:radio_release+0x23/0x27
 [<ffffffff802862dd>] __fput+0xac/0x16c
 [<ffffffff80286547>] fput+0x14/0x16
 [<ffffffff802838e7>] filp_close+0x66/0x71
 [<ffffffff80284d1c>] sys_close+0x8e/0xd1
 [<ffffffff8020b34b>] system_call_after_swapgs+0x7b/0x80


Code: ff f0 ff 0b 0f 94 c0 31 d2 84 c0 74 0b 48 89 df 41 ff d4 ba 01 00 00 00 
5b 41 5c c9 89 d0 c3 55 48 89 e5 53 48 89 fb 48 83 ec 08 <83> 3f 00 75 11 be 
2b 00 00 00 48 c7 c7 46 b9 53 80 e8 d7 33 f2
RIP  [<ffffffff8030cd72>] kref_get+0xc/0x29
 RSP <ffff810065211db8>
CR2: 0000000000000010
---[ end trace 7ada9aa1e484b38f ]---


  parent reply	other threads:[~2008-02-27 21:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17  8:36 2.6.25-rc[12] Video4Linux Bttv Regression Bongani Hlope
2008-02-18 16:11 ` Mauro Carvalho Chehab
2008-02-18 21:20   ` Bongani Hlope
2008-02-18 23:21     ` Bongani Hlope
2008-02-19 14:16       ` Mauro Carvalho Chehab
2008-02-19 20:37         ` Bongani Hlope
2008-02-21  9:03           ` Bongani Hlope
2008-02-26 15:41         ` Robert Fitzsimons
2008-02-27  1:42           ` Robert Fitzsimons
2008-02-27  1:44             ` [PATCH] bttv: Re-enable radio tuner support for VIDIOCGFREQ/VIDIOCSFREQ ioctls Robert Fitzsimons
2008-02-27  1:47             ` [PATCH] bttv: Re-enabling radio support requires the use of struct bttv_fh Robert Fitzsimons
2008-02-27  9:52               ` Mauro Carvalho Chehab
2008-02-27 21:45               ` Bongani Hlope [this message]
2008-02-28  9:25                 ` Robert Fitzsimons
2008-03-17 21:51             ` 2.6.25-rc[12] Video4Linux Bttv Regression Bongani Hlope
2008-03-20 17:22               ` Mauro Carvalho Chehab
2008-03-21 14:55                 ` Bongani Hlope
2008-03-22  0:05                   ` [PATCH] bttv: Add a radio compat_ioctl file operation Robert Fitzsimons
2008-03-22 18:17                     ` Bongani Hlope
2008-03-23  1:01                       ` Mauro Carvalho Chehab
2008-03-23 13:25                         ` Bongani Hlope
2008-03-23 13:50                           ` Mauro Carvalho Chehab
2008-03-24  6:58                             ` Bongani Hlope

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802272345.43209.bonganilinux@mweb.co.za \
    --to=bonganilinux@mweb.co.za \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=robfitz@273k.net \
    --cc=video4linux-list@redhat.com \
    --subject='Re: [PATCH] bttv: Re-enabling radio support requires the use of struct bttv_fh.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).