LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: Daniel.Beschorner@facton.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, rpurdie@rpsys.net
Subject: Re: zlib oops with ipcomp in 2.6.24
Date: Thu, 28 Feb 2008 11:23:55 -0800 (PST)	[thread overview]
Message-ID: <20080228.112355.15717375.davem@davemloft.net> (raw)
In-Reply-To: <20080228175011.GA17185@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 29 Feb 2008 01:50:11 +0800

> [IPCOMP]: Disable BH on output when using shared tfm
> 
> Because we use shared tfm objects in order to conserve memory,
> (each tfm requires 128K of vmalloc memory), BH needs to be turned
> off on output as that can occur in process context.
> 
> Previously this was done implicitly by the xfrm output code.
> That was lost when it became lockless.  So we need to add the
> BH disabling to IPComp directly.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks Herbert.

The xfrm output lockless stuff is only in 2.6.25, so
we should not need this for -stable right?

  parent reply	other threads:[~2008-02-28 19:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 14:05 Beschorner Daniel
2008-02-23  8:03 ` Andrew Morton
2008-02-23 13:22   ` Beschorner Daniel
2008-02-28 17:50     ` Herbert Xu
2008-02-28 18:47       ` Beschorner Daniel
2008-02-28 19:23       ` David Miller [this message]
2008-02-28 19:30         ` Herbert Xu
2008-02-28 19:32           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228.112355.15717375.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Daniel.Beschorner@facton.com \
    --cc=akpm@linux-foundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --subject='Re: zlib oops with ipcomp in 2.6.24' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).