LKML Archive on
help / color / mirror / Atom feed
From: Richard Hacker <>
To: Sam Ravnborg <>
Subject: Re: [PATCH 001/002] scripts/mod/modpost.c: New option -E to load extra symbols
Date: Thu, 28 Feb 2008 11:42:27 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hello Sam,

> At first quick look it looked good and I have only two comments:
> 1) The variable should be named KBUILD_* to fit the general namespace used
I wanted to use the namespace EXTRA_* to continue the line of EXTRA_CFLAGS, 
etc. that were used when building modules. Is that OK? The other names sound 
odd to me: KBUILD_SYMBOLS or KBUILD_EXTRA_SYMBOLS. If you really do not like 
EXTRA_SYMBOLS, which one do you propose?

> 2) The new possibility should be documented in
> Documentation/kbuild/modules.txt
[PATCH 002/002] in this revised series updated scripts/Makefile.modpost to use 
this new feature of modpost, and documented the change as well. Please take a 
look at it:

> PS. Please also cc: if you submit again.
Did it. (For new readers in linux-kbuild: The original patchset can be found 
at: for [PATCH 001/002] for [PATCH 002/002] )

- Richard

  reply	other threads:[~2008-02-28 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28  8:40 Richard Hacker
2008-02-28  9:18 ` Sam Ravnborg
2008-02-28 10:42   ` Richard Hacker [this message]
2008-04-25 18:57 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH 001/002] scripts/mod/modpost.c: New option -E to load extra symbols' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).