LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* x86: potential ioremap() issues
@ 2008-02-28 12:59 Jan Beulich
  2008-02-28 13:24 ` Ingo Molnar
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2008-02-28 12:59 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-kernel

Ingo,

with the new ioremap() implementation I see a couple of (potential)
issues:
- When ioremap_page_range() fails, remove_vm_area() is used rather
  than vunmap() - I think this will cause a 'struct vm_struct' leak.
- While ioremap() continues to happily map RAM pages (with a bogus
  [see below] WARN_ON_ONCE()), cacheability of the memory is not
  being restored in iounmap().
- The check for RAM pages (except for the WARN_ON_ONCE())
  continues to be applied only to lowmem pages.
- The WARN_ON_ONCE() itself is applied to the pfn after the
  preceding loop finished, i.e. to a pfn that doesn't actually participate
  in the operation. Shouldn't it be moved inside the loop?

Thanks for any clarification,
Jan


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-03-03 15:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-28 12:59 x86: potential ioremap() issues Jan Beulich
2008-02-28 13:24 ` Ingo Molnar
2008-02-28 14:30   ` Jan Beulich
2008-02-29 22:04   ` Oliver Pinter
2008-03-03 10:44     ` Ingo Molnar
2008-03-03 15:19       ` Oliver Pinter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).