LKML Archive on
help / color / mirror / Atom feed
From: Oleg Nesterov <>
To: Roland McGrath <>
Cc: Thomas Gleixner <>,
	Pavel Emelyanov <>,
	Andrew Morton <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH 3/3] Consolidate send_sigqueue and send_group_sigqueue
Date: Thu, 28 Feb 2008 18:36:55 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20080228113633.7431C2700FD@magilla.localdomain>

On 02/28, Roland McGrath wrote:
> That code dates from the original introduction of those two functions.
> I can't see any reason why those ever had swapped order of the two checks.
> I think it must have just been sloppy coding in the original work.
> I'm not clear on how the already-queued case could ever happen.  Do we
> really need that check at all?  It shouldn't be possible for the timer to
> be firing when it's already queued, because it won't have been reloaded.
> It only reloads via do_schedule_next_timer after it's dequeued, or because
> a 1 return value said it never was queued.

This is true for the posix timers, but posix cpu timers case is different.
Note the run_posix_cpu_timers()->cpu_timer_fire().


  parent reply	other threads:[~2008-02-28 15:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 12:56 Pavel Emelyanov
2008-02-22 14:41 ` Oleg Nesterov
2008-02-28  4:54   ` Thomas Gleixner
2008-02-28  6:17     ` Oleg Nesterov
     [not found]       ` <20080228113633.7431C2700FD@magilla.localdomain>
2008-02-28 15:36         ` Oleg Nesterov [this message]
2008-02-28 20:14           ` Roland McGrath
2008-02-29 11:32             ` Oleg Nesterov
2008-02-28 22:32         ` Thomas Gleixner
2008-02-28 22:41           ` Roland McGrath
2008-02-29  8:04             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 3/3] Consolidate send_sigqueue and send_group_sigqueue' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).