LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] I2C_ELEKTOR must depend on HAS_IOPORT
Date: Thu, 28 Feb 2008 18:49:12 +0100 [thread overview]
Message-ID: <20080228184912.48cde1f3@hyperion.delvare> (raw)
In-Reply-To: <20080227073728.GD10603@cs181133002.pp.htv.fi>
Hi Adrian,
On Wed, 27 Feb 2008 09:37:28 +0200, Adrian Bunk wrote:
> This patch fixes the following compile error on m32r:
>
> <-- snip -->
>
> ...
> CC [M] drivers/i2c/busses/i2c-elektor.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_setbyte':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:80: error: implicit declaration of function 'iowrite8'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_getbyte':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:90: error: implicit declaration of function 'ioread8'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_init':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:153: error: implicit declaration of function 'ioport_map'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:153: warning: assignment makes pointer from integer without a cast
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'elektor_probe':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:290: error: implicit declaration of function 'ioport_unmap'
> make[4]: *** [drivers/i2c/busses/i2c-elektor.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
>
> ---
> c8a75f0dd2390ae8c8f91c451ff6b0e113d0ebd0 diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 476b0bb..3bed6b9 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -129,7 +129,7 @@ config I2C_DAVINCI
>
> config I2C_ELEKTOR
> tristate "Elektor ISA card"
> - depends on ISA && BROKEN_ON_SMP
> + depends on ISA && HAS_IOPORT && BROKEN_ON_SMP
> select I2C_ALGOPCF
> help
> This supports the PCF8584 ISA bus I2C adapter. Say Y if you own
>
Looks weird to me. As you can see, I2C_ELEKTOR already depends on ISA
and I thought it would be sufficient. Your m32r system has
CONFIG_HAS_IOPORT=n but CONFIG_ISA=y? I fail to see how a system could
have ISA slots but not have IO ports.
--
Jean Delvare
next prev parent reply other threads:[~2008-02-28 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 7:37 Adrian Bunk
2008-02-28 17:49 ` Jean Delvare [this message]
2008-03-01 19:01 ` m32r and ISA Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228184912.48cde1f3@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=bunk@kernel.org \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [2.6 patch] I2C_ELEKTOR must depend on HAS_IOPORT' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).