LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Mark Pearson <devnull.port@googlemail.com>,
	Karol Kozimor <sziwan@hell.org.pl>, Julia Lawall <julia@diku.dk>,
	corentincj@iksaif.net, sziwan@users.sourceforge.net,
	acpi4asus-user@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
Date: Thu, 28 Feb 2008 22:19:48 -0800	[thread overview]
Message-ID: <20080228221948.2602527a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080229061023.GD19198@parisc-linux.org>

On Thu, 28 Feb 2008 23:10:23 -0700 Matthew Wilcox <matthew@wil.cx> wrote:

> On Thu, Feb 28, 2008 at 09:55:03PM -0800, Andrew Morton wrote:
> >  	if (invert)		/* invert target value */
> > -		led_out = !led_out & 0x1;
> > +		led_out = !led_out;
> >  
> >  	if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
> 
> But now you're writing 0xffffffff instead of 1.  I think the suggestion
> of led_out ^= 1 was the correct one.
> 

!0 is 1, not 0xffffffff.

IOW, ! != ~ ;)



  parent reply	other threads:[~2008-02-29  6:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 20:42 Julia Lawall
2008-02-27 17:03 ` Karol Kozimor
2008-02-27 17:41   ` Julia Lawall
2008-02-27 18:29   ` Mark Pearson
2008-02-29  5:55     ` Andrew Morton
2008-02-29  6:10       ` Matthew Wilcox
2008-02-29  6:14         ` Matthew Wilcox
2008-02-29  6:19         ` Andrew Morton [this message]
2008-02-29 11:01       ` Julia Lawall
2008-02-29 11:08         ` Andrew Morton
2008-02-29 18:06       ` Mark Pearson
2008-02-29 21:33         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228221948.2602527a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentincj@iksaif.net \
    --cc=devnull.port@googlemail.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sziwan@hell.org.pl \
    --cc=sziwan@users.sourceforge.net \
    --subject='Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of '\!' and &' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).