LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Paul Jackson <pj@sgi.com>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: trivial clean up to zlc_setup
Date: Fri, 29 Feb 2008 00:05:44 -0800	[thread overview]
Message-ID: <20080229000544.5cf2667e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080229151057.66ED.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Fri, 29 Feb 2008 15:19:39 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> Hi
> 
> I found very small bug during review mel's 2 zonelist patch series.
> 
> this patch is trivial clean up.
> jiffies subtraction may cause overflow problem.
> it shold be used time_after().
> 
> Thanks.
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
> CC: Paul Jackson <pj@sgi.com>
> ---
>  mm/page_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/mm/page_alloc.c
> ===================================================================
> --- a/mm/page_alloc.c   2008-02-18 17:17:25.000000000 +0900
> +++ b/mm/page_alloc.c   2008-02-29 15:17:03.000000000 +0900
> @@ -1294,7 +1294,7 @@ static nodemask_t *zlc_setup(struct zone
>         if (!zlc)
>                 return NULL;
> 
> -       if (jiffies - zlc->last_full_zap > 1 * HZ) {
> +       if (time_after(jiffies, zlc->last_full_zap + HZ)) {
>                 bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST);
>                 zlc->last_full_zap = jiffies;
>         }

That's a mainline bug.  Also present in 2.6.24, maybe earlier.

But it's a minor one - we'll fix it up one second later (yes?)

  reply	other threads:[~2008-02-29  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29  6:19 KOSAKI Motohiro
2008-02-29  8:05 ` Andrew Morton [this message]
2008-02-29  8:30   ` KOSAKI Motohiro
2008-02-29 13:31     ` S.Çağlar Onur
2008-02-29 15:36 ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080229000544.5cf2667e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pj@sgi.com \
    --subject='Re: trivial clean up to zlc_setup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).