LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
@ 2008-02-26 20:42 Julia Lawall
  2008-02-27 17:03 ` Karol Kozimor
  0 siblings, 1 reply; 12+ messages in thread
From: Julia Lawall @ 2008-02-26 20:42 UTC (permalink / raw)
  To: corentincj, sziwan, acpi4asus-user, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---

diff -u -p a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
--- a/drivers/acpi/asus_acpi.c 2008-02-10 22:34:05.000000000 +0100
+++ b/drivers/acpi/asus_acpi.c 2008-02-26 08:00:42.000000000 +0100
@@ -610,7 +610,7 @@ write_led(const char __user * buffer, un
 	    (led_out) ? (hotk->status | ledmask) : (hotk->status & ~ledmask);
 
 	if (invert)		/* invert target value */
-		led_out = !led_out & 0x1;
+		led_out = !(led_out & 0x1);
 
 	if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
 		printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2008-02-29 21:49 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-26 20:42 [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Julia Lawall
2008-02-27 17:03 ` Karol Kozimor
2008-02-27 17:41   ` Julia Lawall
2008-02-27 18:29   ` Mark Pearson
2008-02-29  5:55     ` Andrew Morton
2008-02-29  6:10       ` Matthew Wilcox
2008-02-29  6:14         ` Matthew Wilcox
2008-02-29  6:19         ` Andrew Morton
2008-02-29 11:01       ` Julia Lawall
2008-02-29 11:08         ` Andrew Morton
2008-02-29 18:06       ` Mark Pearson
2008-02-29 21:33         ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).