From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754843AbYB2Crr@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754843AbYB2Crr (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Feb 2008 21:47:47 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755428AbYB2Cr1
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 28 Feb 2008 21:47:27 -0500
Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:40947 "EHLO
	fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754755AbYB2Cr0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Feb 2008 21:47:26 -0500
Date: Fri, 29 Feb 2008 11:47:14 +0900
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Rik van Riel <riel@redhat.com>
Subject: Re: [patch 01/21] move isolate_lru_page() to vmscan.c
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
       Lee Schermerhorn <Lee.Schermerhorn@hp.com>, linux-mm@kvack.org,
       Nick Piggin <npiggin@suse.de>
In-Reply-To: <20080228214141.296335a0@bree.surriel.com>
References: <20080229112120.66E1.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080228214141.296335a0@bree.surriel.com>
Message-Id: <20080229114638.66E4.KOSAKI.MOTOHIRO@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Becky! ver. 2.42 [ja]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> If I understand you right, this is what the incremental patch looks like:
> 
> Index: linux-2.6.25-rc2-mm1/mm/migrate.c
> ===================================================================
> --- linux-2.6.25-rc2-mm1.orig/mm/migrate.c	2008-02-28 21:32:20.000000000 -0500
> +++ linux-2.6.25-rc2-mm1/mm/migrate.c	2008-02-28 21:32:14.000000000 -0500
> @@ -841,16 +841,10 @@ static int do_move_pages(struct mm_struc
>  			goto put_and_set;
>  
>  		err = isolate_lru_page(page);
> -		if (err) {
> -put_and_set:
> -			/*
> -			 * Either remove the duplicate refcount from
> -			 * isolate_lru_page() or drop the page ref if it was
> -			 * not isolated.
> -			 */
> -			put_page(page);
> -		} else
> +		if (!err)
>  			list_add_tail(&page->lru, &pagelist);
> +put_and_set:
> +		put_page(page);
>  set_status:
>  		pp->status = err;
>  	}
> 
> Is this OK for me to commit to my tree?
> (folding it into patch 01/21)

Yes. thanks.