LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: eibach@gdsys.de, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH] usb: add sysfs configuration interface for CP2101
Date: Fri, 29 Feb 2008 12:46:05 -0800	[thread overview]
Message-ID: <20080229124605.24c49ed5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080229144437.GD28849@shadowen.org>

On Fri, 29 Feb 2008 14:44:37 +0000
Andy Whitcroft <apw@shadowen.org> wrote:

> On Fri, Feb 29, 2008 at 02:02:45AM -0800, Andrew Morton wrote:
> > On Fri, 29 Feb 2008 10:02:18 +0100 Dirk Eibach <eibach@gdsys.de> wrote:
> 
> > We have a new strict_strtoul() (and related functions) which will perform
> > proper checking for a valid number.  Please use that interface.
> > 
> > Andy, this is going to happen so much that a "should you have used
> > strict_strtoul?" warning in checkpatch would reduce my email output.
> 
> Sure, will add something.  I wonder if this new interface is documented.

It has kerneldoc.

> I note that this interface is new in -mm at this time.

It is in mainline.

>  So that brings
> up an interesting question as to how one would integrate this check with
> checkpatch.  As checking patches for mainline, this would be an
> incorrect check until that patch merges.  I guess the right thing to do
> is provide a separate patch for checkpatch which adds this check which
> should sit with the patch in your tree which adds the functionality.
> 

It would be easier to just update your kernel tree ;)

      reply	other threads:[~2008-02-29 20:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29  9:02 Dirk Eibach
2008-02-29  9:40 ` Dirk Eibach
2008-02-29 10:02 ` Andrew Morton
2008-02-29 12:31   ` Dirk Eibach
2008-02-29 20:35     ` Andrew Morton
2008-03-03  9:27       ` Dirk Eibach
2008-03-03 15:07         ` Alan Stern
2008-03-03 16:28           ` Greg KH
2008-03-04  7:03             ` Dirk Eibach
2008-03-04 17:52               ` Alan Stern
2008-03-04 19:51               ` Greg KH
2008-04-09 12:16       ` Andy Whitcroft
2008-03-01  0:33     ` Greg KH
2008-02-29 14:44   ` Andy Whitcroft
2008-02-29 20:46     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080229124605.24c49ed5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=eibach@gdsys.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] usb: add sysfs configuration interface for CP2101' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).