LKML Archive on
help / color / mirror / Atom feed
* devres and requesting resources
@ 2008-02-29  0:36 Jeff Garzik
  2008-02-29 11:26 ` Alan Cox
  0 siblings, 1 reply; 10+ messages in thread
From: Jeff Garzik @ 2008-02-29  0:36 UTC (permalink / raw)
  To: Tejun Heo; +Cc: Linux IDE mailing list, LKML

Something I just noticed, which I missed during the initial devres review...

The vast majority of my ATA drivers originally called 
pci_request_regions(), to reserve all regions attached to a device.

In converting to pcim_iomap_regions(), we no longer reserve /all/ 
regions, only the ones requested.

This is actually a bug:  it was intentional to call 
pci_request_regions(), because that ensures that no other software will 
use our resources -- even if we are not actively using the resource in 

Or IOW, I wanted to ensure that there would be no device sharing... 
which this devres conversion accidentally enabled.

The simple fix is obviously to replace pci_request_region() call with 
pci_request_regions() in lib/devres.c, but I wonder if that will break 
any existing driver?


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2008-02-29 19:25 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-29  0:36 devres and requesting resources Jeff Garzik
2008-02-29 11:26 ` Alan Cox
2008-02-29 12:11   ` Jeff Garzik
2008-02-29 12:28     ` Tejun Heo
2008-02-29 14:01       ` Alan Cox
2008-02-29 14:17         ` Tejun Heo
2008-02-29 19:25           ` Jeff Garzik
2008-02-29 17:04         ` Bartlomiej Zolnierkiewicz
2008-02-29 17:04           ` Alan Cox
2008-02-29 13:55     ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).