LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* trivial clean up to zlc_setup
@ 2008-02-29  6:19 KOSAKI Motohiro
  2008-02-29  8:05 ` Andrew Morton
  2008-02-29 15:36 ` Paul Jackson
  0 siblings, 2 replies; 5+ messages in thread
From: KOSAKI Motohiro @ 2008-02-29  6:19 UTC (permalink / raw)
  To: Lee Schermerhorn, Paul Jackson, linux-mm, LKML; +Cc: kosaki.motohiro

Hi

I found very small bug during review mel's 2 zonelist patch series.

this patch is trivial clean up.
jiffies subtraction may cause overflow problem.
it shold be used time_after().

Thanks.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
CC: Paul Jackson <pj@sgi.com>
---
 mm/page_alloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/mm/page_alloc.c
===================================================================
--- a/mm/page_alloc.c   2008-02-18 17:17:25.000000000 +0900
+++ b/mm/page_alloc.c   2008-02-29 15:17:03.000000000 +0900
@@ -1294,7 +1294,7 @@ static nodemask_t *zlc_setup(struct zone
        if (!zlc)
                return NULL;

-       if (jiffies - zlc->last_full_zap > 1 * HZ) {
+       if (time_after(jiffies, zlc->last_full_zap + HZ)) {
                bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST);
                zlc->last_full_zap = jiffies;
        }






^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-29 15:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-29  6:19 trivial clean up to zlc_setup KOSAKI Motohiro
2008-02-29  8:05 ` Andrew Morton
2008-02-29  8:30   ` KOSAKI Motohiro
2008-02-29 13:31     ` S.Çağlar Onur
2008-02-29 15:36 ` Paul Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).