LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Alexey Zaytsev <alexey.zaytsev@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Stefano Brivio <stefano.brivio@polimi.it>,
	Jeff Garzik <jgarzik@pobox.com>, Greg KH <greg@kroah.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
Date: Fri, 29 Feb 2008 23:49:30 +0100	[thread overview]
Message-ID: <200802292349.31415.mb@bu3sch.de> (raw)
In-Reply-To: <20080229205400.GG27212@elte.hu>

On Friday 29 February 2008 21:54:00 Ingo Molnar wrote:
> 
> * Michael Buesch <mb@bu3sch.de> wrote:
> 
> > On Friday 29 February 2008 09:21:19 Andrew Morton wrote:
> > > On Sat, 23 Feb 2008 16:17:55 +0300 Alexey Zaytsev <alexey.zaytsev@gmail.com> wrote:
> > > 
> > > > Theese two patches fix a problem instroduced in Linux 2.6.24, and
> > > > still present in the current Linus' 2.6.25 tree.
> > > > 
> > > > The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
> > > > driver is enabled. This happens because the b44 driver
> > > > needlessly enables the b43_pci_bridge code, which claims
> > > > the same pci ids as the bcm43xx driver. The b43_pci_bridge
> > > > code is needed for the b43{legacy} drivers, but for the
> > > > b44, only the "ssb pci core" is needed.
> > > 
> > > Hate to stick my head into this beehive, but...
> > > 
> > > I have a patch queued (the-scheduled-bcm43xx-removal.patch) which 
> > > will remove this driver from 2.6.26.
> > > 
> > > Is that bad?
> > 
> > Not at all. The b43 driver from 2.6.26 will work. So there's no reason 
> > to keep bcm43xx. Alexey just tested a patch that backports the fix to 
> > 2.6.24 and it works fine.
> 
> yeah, i'd support the removal of it too, if the transition is smooth and 
> the regressions are resolved. And it should be smooth, as long as users 
> are able to load the firmware blob, right? There's also an entry for it 

As far as I can see, yes. The b43 driver is pretty mature these days.
It does base on the codebase of the bcm43xx driver and the most intrusive
changes date back over a year ago. The driver got lots of testing in the
meantime.
I do own the most common device flavours (except the 4311. So if somebody
has one do donate.. :) ) and I don't see any regressions.

Most "regressions" come from people not installing the updated firmware.
But that's an issue we simply cannot solve in the driver.

Of course, as I always said, if some last-minute regression appears, we
will defer the bcm43xx removal. So I hope I'm not _really_ the worst
maintainer ever, although I try hard to, when it comes to patches I
really dislike. ;)

-- 
Greetings Michael.

      reply	other threads:[~2008-02-29 22:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23 13:17 Alexey Zaytsev
2008-02-23 16:20 ` Michael Buesch
2008-02-23 20:37   ` Alexey Zaytsev
2008-02-24 16:26 ` Larry Finger
2008-02-27 20:15   ` John W. Linville
2008-02-27 21:58     ` Michael Buesch
2008-02-28  1:15       ` John W. Linville
2008-02-29  8:21 ` Andrew Morton
2008-02-29 10:05   ` Michael Buesch
2008-02-29 20:54     ` Ingo Molnar
2008-02-29 22:49       ` Michael Buesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802292349.31415.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.zaytsev@gmail.com \
    --cc=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=stefano.brivio@polimi.it \
    --subject='Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).