LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* regression: ntfs build failure in linux-2.6.git on no-mmu: no is_vmalloc_addr()
       [not found] <20080301112959.89C8AA506AF@snoopy.ad.analog.com>
@ 2008-03-01 20:08 ` Mike Frysinger
  0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2008-03-01 20:08 UTC (permalink / raw)
  To: linux-kernel, Andrew Morton; +Cc: uclinux-dist-devel, cooloney

On Saturday 01 March 2008 06:29:59 vapier@blackfin.uclinux.org wrote:
> --- blackfin-2.6/BF548-EZKIT.BF542
> --- blackfin-2.6/BF548-EZKIT.BF544
> --- blackfin-2.6/BF548-EZKIT.BF547
> --- blackfin-2.6/BF548-EZKIT.BF548
> --- blackfin-2.6/BF548-EZKIT.BF549
> --- linux-2.6/BF548-EZKIT.BF542
> --- linux-2.6/BF548-EZKIT.BF544
> --- linux-2.6/BF548-EZKIT.BF547
> --- linux-2.6/BF548-EZKIT.BF548
> --- linux-2.6/BF548-EZKIT.BF549
> --- next-20080229/BF548-EZKIT.BF542
> --- next-20080229/BF548-EZKIT.BF544
> --- next-20080229/BF548-EZKIT.BF547
> --- next-20080229/BF548-EZKIT.BF548
> --- next-20080229/BF548-EZKIT.BF549
> <stdin>:1377:2: warning: #warning syscall timerfd_create not implemented
> <stdin>:1389:2: warning: #warning syscall timerfd_settime not implemented
> <stdin>:1393:2: warning: #warning syscall timerfd_gettime not implemented
> In file included from fs/ntfs/attrib.c:32:
> fs/ntfs/malloc.h: In function 'ntfs_free':
> fs/ntfs/malloc.h:88: error: implicit declaration of function
> 'is_vmalloc_addr' make[2]: *** [fs/ntfs/attrib.o] Error 1
> make[1]: *** [fs/ntfs] Error 2
> make: *** [fs] Error 2

commit 9e2779fa281cfda13ac060753d674bbcaa23367e changed fs/ntfs/malloc.h from
using VMALLOC_* defines to is_vmalloc_addr() (which makes sense), but Blackfin
was defining VMALLOC_* (to basically the range of all memory addresses like
most no-mmu ports)

so we can drop CONFIG_MMU around is_vmalloc_addr() in include/linux/mm.h, or
we can just make it return 1 all the time for no-mmu.  the former sounds
easier.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 3f3ccfe..3b3e134 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -235,7 +235,6 @@ static inline int get_page_unless_zero(struct page *page)
 struct page *vmalloc_to_page(const void *addr);
 unsigned long vmalloc_to_pfn(const void *addr);
 
-#ifdef CONFIG_MMU
 /* Determine if an address is within the vmalloc range */
 static inline int is_vmalloc_addr(const void *x)
 {
@@ -243,7 +242,6 @@ static inline int is_vmalloc_addr(const void *x)
 
 	return addr >= VMALLOC_START && addr < VMALLOC_END;
 }
-#endif
 
 static inline struct page *compound_head(struct page *page)
 {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-01 20:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20080301112959.89C8AA506AF@snoopy.ad.analog.com>
2008-03-01 20:08 ` regression: ntfs build failure in linux-2.6.git on no-mmu: no is_vmalloc_addr() Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).