LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] block/blk-tag.c should #include "blk.h"
@ 2008-03-01 16:17 Adrian Bunk
  2008-03-01 18:36 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-03-01 16:17 UTC (permalink / raw)
  To: axboe; +Cc: linux-kernel

Every file should include the headers containing the externs for its 
global functions (in this case for __blk_queue_free_tags()).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
0edfc0436c5d278bb3272aa6ce3044052b137f99 foobar
diff --git a/block/blk-tag.c b/block/blk-tag.c
index a8c37d4..4780a46 100644
--- a/block/blk-tag.c
+++ b/block/blk-tag.c
@@ -6,6 +6,8 @@
 #include <linux/bio.h>
 #include <linux/blkdev.h>
 
+#include "blk.h"
+
 /**
  * blk_queue_find_tag - find a request by its tag and queue
  * @q:	 The request queue for the device


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] block/blk-tag.c should #include "blk.h"
  2008-03-01 16:17 [2.6 patch] block/blk-tag.c should #include "blk.h" Adrian Bunk
@ 2008-03-01 18:36 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-03-01 18:36 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel

On Sat, Mar 01 2008, Adrian Bunk wrote:
> Every file should include the headers containing the externs for its 
> global functions (in this case for __blk_queue_free_tags()).

Thanks Adrian, applied all of them.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-01 18:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-01 16:17 [2.6 patch] block/blk-tag.c should #include "blk.h" Adrian Bunk
2008-03-01 18:36 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).