From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759777AbYCANgh (ORCPT ); Sat, 1 Mar 2008 08:36:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755646AbYCANg3 (ORCPT ); Sat, 1 Mar 2008 08:36:29 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:40312 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755182AbYCANg3 (ORCPT ); Sat, 1 Mar 2008 08:36:29 -0500 Date: Sat, 01 Mar 2008 22:35:44 +0900 From: KOSAKI Motohiro To: Rik van Riel Subject: Re: [patch 09/21] (NEW) improve reclaim balancing Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org, Lee Schermerhorn , linux-mm@kvack.org In-Reply-To: <20080228192928.648701083@redhat.com> References: <20080228192908.126720629@redhat.com> <20080228192928.648701083@redhat.com> Message-Id: <20080301221216.529E.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi > + /* > + * Even if we did not try to evict anon pages at all, we want to > + * rebalance the anon lru active/inactive ratio. > + */ > + if (inactive_anon_low(zone)) > + shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc, > + priority); > + you want check global zone status, right? if so, this statement only do that at global scan. - kosaki --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/mm/vmscan.c =================================================================== --- a/mm/vmscan.c 2008-03-01 22:18:42.000000000 +0900 +++ b/mm/vmscan.c 2008-03-01 22:42:42.000000000 +0900 @@ -1319,9 +1319,9 @@ static unsigned long shrink_zone(int pri * Even if we did not try to evict anon pages at all, we want to * rebalance the anon lru active/inactive ratio. */ - if (inactive_anon_low(zone)) + if (scan_global_lru(sc) && inactive_anon_low(zone)) shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc, priority); throttle_vm_writeout(sc->gfp_mask); return nr_reclaimed;