From: "Ahmed S. Darwish" <darwish.07@gmail.com> To: Casey Schaufler <casey@schaufler-ca.com> Cc: Adrian Bunk <bunk@kernel.org>, Chris Wright <chrisw@sous-sol.org>, Stephen Smalley <sds@tycho.nsa.gov>, James Morris <jmorris@namei.org>, Eric Paris <eparis@parisplace.org>, Alexey Dobriyan <adobriyan@sw.ru>, LKML <linux-kernel@vger.kernel.org>, LSM-ML <linux-security-module@vger.kernel.org>, Anrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH -v2 -mm] LSM: Add security= boot parameter Date: Sun, 2 Mar 2008 09:49:12 +0200 Message-ID: <20080302074912.GA3215@ubuntu> (raw) In-Reply-To: <20080301232708.GA625@ubuntu> On Sun, Mar 02, 2008 at 01:27:08AM +0200, Ahmed S. Darwish wrote: > Hi!, > ... > LSM modules must check now if they are allowed to register > by calling security_module_enable(ops) first. Modify SELinux > and SMACK to do so. > ... > > +/* Boot-time LSM user choice */ > +static char chosen_lsm[SECURITY_NAME_MAX + 1]; > +static atomic_t security_ops_registered = ATOMIC_INIT(0); > ... > +int security_module_enable(struct security_operations *ops) > +{ > + if (!ops || !ops->name) > + return 0; > + > + if (!*chosen_lsm && !atomic_read(&security_ops_registered)) > + return 1; > + ... > @@ -90,6 +134,7 @@ int register_security(struct security_operations *ops) > return -EAGAIN; > > security_ops = ops; > + atomic_inc(&security_ops_registered); > I'm worried about an implementation detail here. Must the LSM init calls sequence: asmlinkage void __init start_kernel(void) { preempt_disable(); ... security_init(); ... int __init security_init(void) { ... do_security_initcalls(); } static void __init do_security_initcalls(void) { initcall_t *call; call = __security_initcall_start; while (call < __security_initcall_end) { (*call) (); call++; } } be SMP safe ? In other words, can the two LSMs 'security_initcall()'s (i.e. smack_init() and selinux_init()) be executed concurrently ? If so, this patch won't be safe. I'll send a modified one once I know the answer. Thanks everybody, -- "Better to light a candle, than curse the darkness" Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-01 19:07 [RFC PATCH -mm] LSM: Add lsm= " Ahmed S. Darwish 2008-03-01 20:28 ` Casey Schaufler 2008-03-01 21:11 ` Adrian Bunk 2008-03-01 21:29 ` Casey Schaufler 2008-03-01 23:27 ` [PATCH -v2 -mm] LSM: Add security= " Ahmed S. Darwish 2008-03-02 3:41 ` Casey Schaufler 2008-03-02 7:55 ` Ahmed S. Darwish 2008-03-02 7:49 ` Ahmed S. Darwish [this message] 2008-03-02 10:59 ` [PATCH -v3 " Ahmed S. Darwish 2008-03-02 18:37 ` Casey Schaufler 2008-03-03 8:29 ` James Morris 2008-03-03 15:35 ` Ahmed S. Darwish 2008-03-03 15:54 ` Stephen Smalley 2008-03-03 21:24 ` [PATCH -v4 " Ahmed S. Darwish 2008-03-03 22:16 ` James Morris 2008-03-04 3:04 ` [PATCH -v5 " Ahmed S. Darwish 2008-03-04 4:07 ` James Morris 2008-03-05 22:29 ` Andrew Morton 2008-03-05 22:56 ` Ahmed S. Darwish 2008-03-05 23:06 ` Ahmed S. Darwish 2008-03-05 22:56 ` James Morris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080302074912.GA3215@ubuntu \ --to=darwish.07@gmail.com \ --cc=adobriyan@sw.ru \ --cc=akpm@linux-foundation.org \ --cc=bunk@kernel.org \ --cc=casey@schaufler-ca.com \ --cc=chrisw@sous-sol.org \ --cc=eparis@parisplace.org \ --cc=jmorris@namei.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=sds@tycho.nsa.gov \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git