LKML Archive on
help / color / mirror / Atom feed
From: Adrian Bunk <>
To: Bartlomiej Zolnierkiewicz <>
Subject: ide_register_hw(): buggy code
Date: Sun, 2 Mar 2008 17:19:24 +0200	[thread overview]
Message-ID: <> (raw)

The Coverity checker spotted the following bogus change to 
ide_register_hw() in commit 9e016a719209d95338e314b46c3012cc7feaaeec:

<--  snip  -->

+               hwif = ide_deprecated_find_port(hw->io_ports[IDE_DATA_OFFSET]);
+               index = hwif->index;
+               if (hwif)
+                       goto found;
                for (index = 0; index < MAX_HWIFS; index++)

<--  snip  -->

It's impossible to reach the for() loop without Oopsing before.

Can you either fix this for 2.6.25 or push your patch that removes 
ide_register_hw() for 2.6.25?



       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

             reply	other threads:[~2008-03-02 15:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 15:19 Adrian Bunk [this message]
2008-03-03 16:03 ` Peter Teoh
2008-03-03 22:29   ` Bartlomiej Zolnierkiewicz
2008-03-04  1:01     ` Peter Teoh
2008-03-04 20:57       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: ide_register_hw(): buggy code' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).