LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: Jean Delvare <khali@linux-fr.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: problem with starting 2.6.25-rc1 and latest git
Date: Sun, 2 Mar 2008 22:09:21 +0100	[thread overview]
Message-ID: <200803022209.22227.m.kozlowski@tuxland.pl> (raw)
In-Reply-To: <20080226230532.76f63db3@hyperion.delvare>

Hello Jean,

> On Tue, 26 Feb 2008 17:04:46 +0100, Mariusz Kozlowski wrote:
> > I can reproduce this here on rc3 as well. Weird - on git tree before
> > rc3 was released this didn't happen. rc2 and rc1 are broken. I also
> > don't know why nobody else see this but us :) And not sure how
> > to debug it some more or provide more accurate information.
> 
> Here's a quick and dirty debugging patch I wrote in an attempt to find
> out what was going on. Unfortunately, the problem never happened to me
> when this debug patch was applied. Maybe you'll have more "luck"?

Sorry for the late response. I tried your patch and it seems we share this 'luck'.
I couldn't reproduce that. I have a few other ideas to try. I'll see what I can do. 
Unfortunately my time got limited recently so I'm lagging behind LKML and
kernel stuff :-/

	Mariusz

>  kernel/module.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- linux-2.6.25-rc1.orig/kernel/module.c	2008-02-14 09:16:15.000000000 +0100
> +++ linux-2.6.25-rc1/kernel/module.c	2008-02-14 23:20:22.000000000 +0100
> @@ -2153,8 +2153,10 @@ sys_init_module(void __user *umod,
>  		return PTR_ERR(mod);
>  	}
>  
> +	printk(KERN_WARNING "loading module %s, checkpoint 1\n", mod->name);
>  	/* Drop lock so they can recurse */
>  	mutex_unlock(&module_mutex);
> +	printk(KERN_WARNING "loading module %s, checkpoint 2\n", mod->name);
>  
>  	blocking_notifier_call_chain(&module_notify_list,
>  			MODULE_STATE_COMING, mod);
> @@ -2177,6 +2179,7 @@ sys_init_module(void __user *umod,
>  
>  	/* Now it's a first class citizen! */
>  	mutex_lock(&module_mutex);
> +	printk(KERN_WARNING "loading module %s, checkpoint 3\n", mod->name);
>  	mod->state = MODULE_STATE_LIVE;
>  	/* Drop initial reference. */
>  	module_put(mod);
> @@ -2186,6 +2189,7 @@ sys_init_module(void __user *umod,
>  	mod->init_size = 0;
>  	mod->init_text_size = 0;
>  	mutex_unlock(&module_mutex);
> +	printk(KERN_WARNING "loading module %s, checkpoint 4\n", mod->name);
>  	wake_up(&module_wq);
>  
>  	return 0;
> 
> 



  reply	other threads:[~2008-03-02 21:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 22:16 problem with starting 2.5.25-rc1 " Mariusz Kozlowski
2008-02-13 23:27 ` Mariusz Kozlowski
2008-02-14 22:01   ` problem with starting 2.6.25-rc1 " Jean Delvare
2008-02-18 13:28   ` problem with starting 2.5.26-rc1 " Jean Delvare
2008-02-19 23:56     ` Mariusz Kozlowski
2008-02-21 22:10       ` Mariusz Kozlowski
2008-02-26 12:02     ` Jean Delvare
2008-02-26 16:04       ` problem with starting 2.6.25-rc1 " Mariusz Kozlowski
2008-02-26 22:05         ` Jean Delvare
2008-03-02 21:09           ` Mariusz Kozlowski [this message]
2008-02-14 23:47 ` problem with starting 2.5.25-rc1 " Greg KH
2008-02-15  8:28   ` Mariusz Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803022209.22227.m.kozlowski@tuxland.pl \
    --to=m.kozlowski@tuxland.pl \
    --cc=gregkh@suse.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --subject='Re: problem with starting 2.6.25-rc1 and latest git' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).